Fix PictGenerate to clear previous results before generating new ones #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com>
Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] PictGenerate does not clean previous results before generating the new ones
Fix PictGenerate to clear previous results before generating new ones
May 19, 2025
Member
|
@copilot just keep changes needed in model.cpp and discard the rest |
Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com>
Contributor
Author
jaccz
approved these changes
Jan 9, 2026
takeyaqa
added a commit
to takeyaqa/pict-wasm
that referenced
this pull request
Jan 12, 2026
…microsoft#134) (#39) * Initial plan for issue * Fix PictGenerate to clear previous results before generating new ones * Fix PictGenerate to clear previous results and update .gitignore * Remove libpict.so binary and revert .gitignore changes --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com>
takeyaqa
added a commit
to takeyaqa/pict-wasm
that referenced
this pull request
Jan 25, 2026
* Fix PictGenerate to clear previous results before generating new ones (microsoft#134) * Initial plan for issue * Fix PictGenerate to clear previous results before generating new ones Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Fix PictGenerate to clear previous results and update .gitignore Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Remove libpict.so binary and revert .gitignore changes Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Adding handing for DBCS characters (microsoft#140) * Initial plan for issue * Fix PictGenerate to clear previous results before generating new ones Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Fix PictGenerate to clear previous results and update .gitignore Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Remove libpict.so binary and revert .gitignore changes Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Fix Unicode handling and add test for Japanese Kanji characters --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * Add comprehensive development guidelines for the PICT repository * chore: resolve conflict * chore: resolve conflict * Revert "chore: resolve conflict" This reverts commit 3087955. * Revert "chore: resolve conflict" This reverts commit 3870bb6. * chore: remove copilot instructions document --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> Co-authored-by: Jacek Czerwonka <jacekcz@microsoft.com>
takeyaqa
added a commit
to takeyaqa/pict-wasm
that referenced
this pull request
Jan 25, 2026
* Fix PictGenerate to clear previous results before generating new ones (microsoft#134) * Initial plan for issue * Fix PictGenerate to clear previous results before generating new ones Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Fix PictGenerate to clear previous results and update .gitignore Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Remove libpict.so binary and revert .gitignore changes Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Adding handing for DBCS characters (microsoft#140) * Initial plan for issue * Fix PictGenerate to clear previous results before generating new ones Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Fix PictGenerate to clear previous results and update .gitignore Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Remove libpict.so binary and revert .gitignore changes Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> * Fix Unicode handling and add test for Japanese Kanji characters --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * Add comprehensive development guidelines for the PICT repository --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: jaccz <9115223+jaccz@users.noreply.github.com> Co-authored-by: Jacek Czerwonka <jacekcz@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.