Skip to content

fix install command quoting on Windows cmd#789

Open
mturac wants to merge 1 commit into
microsoft:mainfrom
mturac:fix-40076
Open

fix install command quoting on Windows cmd#789
mturac wants to merge 1 commit into
microsoft:mainfrom
mturac:fix-40076

Conversation

@mturac

@mturac mturac commented Jun 19, 2026

Copy link
Copy Markdown

Fixes microsoft/playwright#40076

Summary

  • quote Install Playwright flags with double quotes on Windows so cmd does not pass literal single quotes
  • add regression coverage for the generated terminal command

Tests

  • npx playwright test tests/installer.spec.ts --project=default
  • npx eslint src/installer.ts tests/installer.spec.ts
  • npx tsc --noEmit
  • npm run lint
  • npm run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Test: Playwright Install in VSCode command Generated wrong command.

1 participant