Introduce a new lint: avoid block namespace #2862
Open
+208
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed a (now trivial) lint for avoiding explicit block namespace
…ay to avoid changing all the tests. if needed it can still be added there on demand
filipw
requested review from
billti,
idavis,
minestarks and
swernli
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Q# best practice is to NOT use namespace blocks to enclose code, and I thought this might be a good candidate for adding a new lint.
This PR introduces such lint, at the
Allowlevel by default to not be invasive. If the syntax is deprecated at some point, it could be reused and updated to a warn.Once configured to warn this is how it looks like:
I did not want to highlight the whole namespace as it was visually too aggressive so I opted for the name only.
I hope this makes sense and adds some value. It was easy to do with minimal changes only.
We did something similar years ago in Omnisharp 🙂