Merged
Conversation
mrwnmsr
approved these changes
Mar 29, 2026
kmaziarz
added a commit
that referenced
this pull request
Mar 31, 2026
d7a3b5a to
b8a54de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During integration with
syntheseus, I found a conflict between the current dependency pins in RetroChimera and those of the MEGAN model: we have a strict pin oftensorboard==2.12.0, which is not compatible withtensorflow==2.20.0pinned in MEGAN. However, RetroChimera itself doesn't use TensorBoard directly anymore: we used to use it for logging, but have since switched to Weights & Biases. It is still an indirect dependency throughsyntheseus-root-aligned->OpenNMT-py->tensorboard>=2.3; after dropping the strict pin inpyproject.toml, the dependency resolver can choose whatever works for MEGAN and OpenNMT (in this case, the newest2.20.0is fine).Also, I raise the minimum version of
syntheseusto0.7.2, to pull in a recent checkpoint downloading bugfix from0.7.2.