Bump react & react-dom#3885
Closed
dannyvv wants to merge 5 commits into
Closed
Conversation
dannyvv
requested review from
JasonVMo,
Saadnajmi,
acoates-ms and
tido64
as code owners
JasonVMo
approved these changes
Dec 6, 2025
JustSlone
approved these changes
Dec 6, 2025
tido64
requested changes
Dec 8, 2025
Member
There was a problem hiding this comment.
This bump will cause runtime issues that we're currently not catching on CI. The React renderer is embedded with each React Native release. Bumping the package doesn't patch these bits. They're simply there so that we can point at source files when debugging code. If the React package is out of sync with what is embedded in React Native, the latter will fail on startup.
Meta will patch the embedded React renderer within this week. I'm going to block this PR until we can bump React Native.
JasonVMo
approved these changes
Dec 8, 2025
JasonVMo
requested changes
Dec 8, 2025
JasonVMo
left a comment
JasonVMo
left a comment
Collaborator
There was a problem hiding this comment.
Revoking my approval given Tommy's comments.
Member
Author
|
Will leave the fix up to Tommy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump react and react-dom int he repo and update the profiles so users will bump to prevent CVE in them.
Test plan