Refactor repeated object property access to destructuring across repo - #5747
Merged
Ian Clanton-Thuon (iclanton) merged 8 commits intoApr 6, 2026
Merged
Conversation
…gin constructors Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/d16ff30b-dbf7-4053-9480-28378c1626b8 Co-authored-by: iclanton <5010588+iclanton@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/69ee967b-8010-4fce-9002-5746b3573f14 Co-authored-by: iclanton <5010588+iclanton@users.noreply.github.com>
Member
|
Copilot - this change needs changefiles. Run None of this should affect package consumers, right? |
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/cbc09497-8eb2-4b35-a252-1cb371b05810 Co-authored-by: iclanton <5010588+iclanton@users.noreply.github.com>
Contributor
Author
Correct, none of this affects package consumers — purely mechanical destructuring with no behavioral changes. Added change files with |
Ian Clanton-Thuon (iclanton)
marked this pull request as ready for review
April 5, 2026 04:34
Ian Clanton-Thuon (iclanton)
enabled auto-merge (squash)
April 5, 2026 04:34
David Michon (dmichon-msft)
left a comment
David Michon (dmichon-msft)
left a comment
Contributor
There was a problem hiding this comment.
Copilot These changes are incomplete. Defaulting should also be handles as part of migrating to destructuring.
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/2fa38687-8cb7-4932-b927-0db70e54c476 Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Contributor
Author
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/2fa38687-8cb7-4932-b927-0db70e54c476 Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
David Michon (dmichon-msft)
approved these changes
Apr 6, 2026
David Michon (dmichon-msft)
left a comment
David Michon (dmichon-msft)
left a comment
Contributor
There was a problem hiding this comment.
Just one minor adjustment left, otherwise looks good
Ian Clanton-Thuon (iclanton)
deleted the
copilot/refactor-repeated-property-references
branch
April 6, 2026 22:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
watch,phase.phaseName)weight,metadata)watchDebounceMs)rushAlertsState)textRewriters)defaultParameters)readFile,globsToIgnore,terminal)loginFlowFailover)uploadMethod,headers,cacheKeyPrefix,minHttpRetryDelayMs)globalRouting)