Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,6 @@ jobs:
fail-fast: false
matrix:
include:
# When Node 18 is removed, remove the special cases in
# - build-tests-samples/heft-storybook-v9-react-tutorial/build.js
# - build-tests-samples/heft-storybook-v9-react-tutorial-app/build.js
# - The "globalOverrides" entry for "@vscode/vsce>cheerio" in common/config/rush/pnpm-config.json
# - libraries/module-minifier/src/cryptoPolyfill.ts
- NodeVersion: 18.20.x
NodeVersionDisplayName: 18
OS: ubuntu-latest
- NodeVersion: 20.18.x
NodeVersionDisplayName: 20
OS: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/file-doc-tickets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Use nodejs
uses: actions/setup-node@v6
with:
node-version: 16
node-version: 20
- name: Parse PR body
run: |
cat <<-"EOF" > event.json
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
"operationSettings": [
{
"operationName": "_phase:lite-build",
"outputFolderNames": ["dist"],
// This project builds differently between Node 18 and other versions of Node
"dependsOnNodeVersion": "major"
"outputFolderNames": ["dist"]
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"build": "heft build --clean --storybook",
"_phase:lite-build": "node ./build"
"_phase:lite-build": "heft run --only build -- --clean --storybook"
},
"dependencies": {
"heft-storybook-v9-react-tutorial": "workspace: *"
Expand Down
32 changes: 0 additions & 32 deletions build-tests-samples/heft-storybook-v9-react-tutorial/build.js

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
"operationSettings": [
{
"operationName": "_phase:build",
"outputFolderNames": [".heft", "lib-esm", "lib-commonjs", "dist"],
// This project builds differently between Node 18 and other versions of Node
"dependsOnNodeVersion": "major"
"outputFolderNames": [".heft", "lib-esm", "lib-commonjs", "dist"]
},
{
"operationName": "_phase:test",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"start": "heft build-watch",
"storybook": "heft build-watch --serve --storybook",
"build-storybook": "heft build --storybook",
"_phase:build": "node ./build",
"_phase:build": "heft run --only build -- --clean --storybook",
"_phase:test": "heft run --only test -- --clean"
},
"dependencies": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Tests Rush yarn mode by:
Before running these tests:
1. Build Rush locally: `rush build --to rush`
2. Build this test project: `rush build --to rush-package-manager-integration-test`
3. Ensure you have Node.js 18+ installed
3. Ensure you have Node.js 20+ installed

## Running the Tests

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class TestHelper {
];

// Update nodeSupportedVersionRange to match current environment
rushJson.nodeSupportedVersionRange = '>=18.0.0';
rushJson.nodeSupportedVersionRange = '>=20.0.0';

await JsonFile.saveAsync(rushJson, rushJsonPath, { updateExistingFile: true });
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"changes": [
{
"packageName": "@rushstack/credential-cache",
"comment": "Remove the Node.js 18 explicit resource management symbol polyfill.",
"type": "patch"
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"changes": [
{
"packageName": "@rushstack/heft-node-rig",
"comment": "Expose ES2022 library definitions in the default TypeScript configuration.",
"type": "patch"
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"changes": [
{
"packageName": "@rushstack/module-minifier",
"comment": "Remove the Node.js 18 Web Crypto polyfill.",
"type": "patch"
}
]
}
4 changes: 0 additions & 4 deletions common/config/rush/pnpm-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -296,10 +296,6 @@
// The React 17 types depend on a specific version of the scheduler types
"@types/react@17.0.74>@types/scheduler": "0.16.8",

// Newer versions of `cheerio` have a dependency on `undici`, which does not support Node 18.
// Remove when we drop support for Node 18
"@vscode/vsce>cheerio": "1.0.0-rc.12",

// `loader-utils@2.0.0` has a vulnerability
"loader-utils@^2.0.0": "2.0.4",

Expand Down
Loading