Fix change verification after peer dependency version bumps - #6012
Merged
Bharat Middha (bmiddha) merged 3 commits intoSep 4, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Bharat Middha (bmiddha)
force-pushed
the
bharatmiddha-microsoft-fix-version-bump-change-verify
branch
from
September 4, 2026 23:00
9d8be41 to
b9bea15
Compare
David Michon (dmichon-msft)
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the remaining
rush change --verifyfalse positives afterrush version --bumpseen in the automatedrushandnoRushbump PRs (#6009 and #6010).When
excludeVersionOnlyChangesis enabled,ProjectChangeAnalyzernow ignores a changed project-rootpackage.jsononly when:versionchanged;peerDependenciesis unchanged.This intentionally permits arbitrary peer dependency additions, removals, or range rewrites alongside the package's own version bump. Changes to
dependencies,devDependencies,optionalDependencies, or any unrelated package field remain substantive and still require a change file. Existing rootCHANGELOG.md/CHANGELOG.jsonhandling is unchanged.Validation
node ../../common/scripts/install-run-rushx.js test --test-path-pattern ProjectChangeAnalyzerfromlibraries/rush-lib: 34 passed.node common/scripts/install-run-rush.js build --to @microsoft/rush-lib: passed, including TypeScript, ESLint, and API Extractor.lib-commonjsanddistoutput into clean detachedorigin/mainsnapshots, then invoked the engine directly rather than allowinginstall-run-rushto select published Rush 5.178.1:node libraries/rush-lib/lib-commonjs/start.js version --bump --version-policy rushnode libraries/rush-lib/lib-commonjs/start.js change --verifypassed.node libraries/rush-lib/lib-commonjs/start.js version --bump --version-policy noRushnode libraries/rush-lib/lib-commonjs/start.js change --verifypassed.noRushbump, manually changed and staged@rushstack/heft-lint-plugin's non-peerdependencies.semverrange from~7.7.4to~7.7.3.change --verifyfailed with exit code 1 and reported@rushstack/heft-lint-plugin, as expected.The automated pipelines currently select published Rush 5.178.1 through
install-run-rush. Existing bump PRs will not gain this behavior until a Rush release containing this fix is published and selected (or an equivalent preview/local selection is used) before regenerating the bumps.