Fix split package publishing flows - #6021
Open
Bharat Middha (bmiddha) wants to merge 4 commits into
Open
Conversation
Restore the old publishing cohort semantics in the split bump pipelines, filter package artifacts through the approved feed proxy, and allow recovery publishing from a specific bump run. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use common/config/rush/.npmrc-publish as the single source of truth for package existence checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the individual package bump before the Rush lockstep bump in the Rush release flow, package both cohorts together, and keep the scheduled non-Rush-only flow isolated. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the publishing behavior that was lost when the Rush and non-Rush flows were split.
common/config/rush/.npmrc-publishFixes #6017
Root cause
noRushis a pipeline cohort label, not a real Rush version policy. Passing it torush publish --version-policyproduced an empty package artifact. Separately,rush version --bump --version-policy rushstill applied individual package changes, so both split bump pipelines changed the same packages.This left
@rushstack/node-core-library@5.24.1merged without a publishable non-Rush artifact.Recovery
Once this PR is available to the pipeline, queue the non-Rush bump pipeline from this branch. Its artifact will retain unpublished
@rushstack/node-core-library@5.24.1. Then queue the non-Rush ESRP pipeline withBumpPipelineRunIdOverrideset to that bump run ID.