Adding more extensions to gitattributes#126
Open
samedder wants to merge 3 commits intomicrosoft:masterfrom
samedder:dev/edwardsa/moreattrs
Open
Adding more extensions to gitattributes#126samedder wants to merge 3 commits intomicrosoft:masterfrom samedder:dev/edwardsa/moreattrs
samedder wants to merge 3 commits intomicrosoft:masterfrom
samedder:dev/edwardsa/moreattrs
Conversation
Contributor
|
Not a fan that this implicitly states that binaries like ".exe" or ".zip" can be committed to the repo. However, for binaries that do exist like the PNG files, I am ok with this. Maybe we can add most of these to the gitignore instead? I'd let the images slide, but I think most of these belong there instead. |
Collaborator
Author
|
@bpm-ms agreed, changed so they're ignored now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding common extensions and other known extensions to be binary. Inspired by #88.