Enable usage of async foreach on SF IAsyncEnumerable#470
Open
AndreyTretyak wants to merge 2 commits intomicrosoft:masterfrom
Open
Enable usage of async foreach on SF IAsyncEnumerable#470AndreyTretyak wants to merge 2 commits intomicrosoft:masterfrom
AndreyTretyak wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will allow using
ServiceFabric.Data.IAsyncEnumerable<T>in theasync foreach, since it uses duck typing.So instead of manually working with enumerator we can write:
This will NOT allow using the extension method of
System.Collection.Generic.IAsyncEnumerable<T>likeWithCancelationorConfigureAwaitin order to do that interface needs to be implemented.This change could help with following issue #406