Skip to content

Filter reactions where one of the reactants is the product#148

Open
jla-gardner wants to merge 1 commit intomicrosoft:mainfrom
jla-gardner:jla-gardner/remove-reactant-product-repetition
Open

Filter reactions where one of the reactants is the product#148
jla-gardner wants to merge 1 commit intomicrosoft:mainfrom
jla-gardner:jla-gardner/remove-reactant-product-repetition

Conversation

@jla-gardner
Copy link
Copy Markdown
Contributor

No description provided.

@jla-gardner jla-gardner changed the title filter hallucinations filter reactions where one of the reactants is the product Feb 13, 2026
@jla-gardner
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@jla-gardner jla-gardner force-pushed the jla-gardner/remove-reactant-product-repetition branch from 529b0bd to 6aa1b26 Compare February 13, 2026 16:36
Copy link
Copy Markdown
Collaborator

@AustinT AustinT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I vaguely recall thinking about this problem when initially implementing this library but forget why I didn't include a kwarg like this. Thanks for implementing!

@kmaziarz kmaziarz changed the title filter reactions where one of the reactants is the product Filter reactions where one of the reactants is the product Mar 3, 2026
@kmaziarz kmaziarz self-requested a review March 3, 2026 18:04
Copy link
Copy Markdown
Contributor

@kmaziarz kmaziarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Before merging, remember to update the CHANGELOG, and also fill in the PR description (see any other PR e.g. #144), which will then populate the commit message of the merge commit added to main 🙂

@kmaziarz kmaziarz force-pushed the jla-gardner/remove-reactant-product-repetition branch from 6aa1b26 to 0331b38 Compare March 30, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants