Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for sessions and shared channel functionality to the Teams API models. The changes introduce new data models and extend existing ones to properly represent shared channel memberships, user actions performed on behalf of others, and app information.
Key changes include:
- Addition of
MembershipSourcemodel to track the source and type of team/channel memberships - Extension of
ChannelDatato include shared channel events, membership sources, and app information - Introduction of
OnBehalfOfandAppInfomodels for delegated actions and app metadata
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/api/src/microsoft/teams/api/models/membership_source.py | New model defining membership source properties including tenant and team information |
| packages/api/src/microsoft/teams/api/models/channel_data/team_info.py | Adds tenant_id field and renames team_type to type for consistency |
| packages/api/src/microsoft/teams/api/models/channel_data/on_behalf_of.py | New model for tracking delegated user actions |
| packages/api/src/microsoft/teams/api/models/channel_data/channel_data.py | Extends with shared channel fields, membership source, and app info |
| packages/api/src/microsoft/teams/api/models/channel_data/app_info.py | New model for app identification and versioning |
| packages/api/src/microsoft/teams/api/models/channel_data/init.py | Updates exports to include new models |
| packages/api/src/microsoft/teams/api/models/account.py | Adds membershipSources field to Account model |
| """List of teams that a channel was unshared from.""" | ||
|
|
||
| membership_source: Optional[MembershipSource] = None | ||
| """Information about the source of the member that was added or removed froma shared channel.""" |
There was a problem hiding this comment.
Corrected spacing in 'froma' to 'from a'.
Suggested change
| """Information about the source of the member that was added or removed froma shared channel.""" | |
| """Information about the source of the member that was added or removed from a shared channel.""" |
Comment on lines
40
to
41
|
|
||
|
|
There was a problem hiding this comment.
The membershipSources field is missing a docstring. Add a comment or docstring explaining its purpose, consistent with the documentation style used for other fields in this class.
Suggested change
| """ | |
| The sources that provide membership information for the account. | |
| """ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.