WIP: engineering: allow rerun of update that has failed health check #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables Trident to rerun updates that have failed health checks by adding AbUpdateHealthCheckFailed to the servicing states that allow update reruns.
- Added
ServicingState::AbUpdateHealthCheckFailedto the match arm that handles failed update reruns, alongsideAbUpdateFinalizedandProvisioned
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ndubchak
approved these changes
Nov 13, 2025
Contributor
|
Do we need to then update the state diagram(s)? |
Member
Author
i don't think so. but i'm going to do a little more thinking on states before merging this. |
bfjelds
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Trident currently has special casing to allow rerun of
trident udpatefor failed update in AbUpdateFinalized state. Enable similar for AbUpdateHealthCheckFailed state.