bug: Fix log that is checked in A/B update e2e test #383
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfjelds
reviewed
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the A/B update e2e test by correcting the log message pattern that is checked in the test. The change updates the expected stderr message from "Staging of update 'AbUpdate' succeeded" to "Staging of A/B update succeeded" to match the actual output format.
Key Changes
- Updated the string check in
triggerTridentUpdateto look for "Staging of A/B update succeeded" instead of "Staging of update 'AbUpdate' succeeded"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bfjelds
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
ab_update.gois checking for an outdated log from Trident.Also, add separate
stageandfinalizetesting to-cipipeline so we catch failures faster.