Conversation
Member
|
Why do we need this after #210? I renamed the |
Member
Author
|
I think I misunderstood the totality of what #210 was renaming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the structure @gabritto set up for the fuzzer to allow manually triggered "tsserver" user tests to run (aka
test tsserver top###)I decided to continue calling them "tsserver" for the
ENTRYPOINTparameter for simplicity, so that the pipeline (and bot) need less changes. The two entrypoint parameters continue to betscandtsserver, and if it'stsserver, the correct lsp vs tsserver infrastructure is chosen based on if we're testing tsgo or not.(I'm also open to not doing that and making the changes in the pipeline interface/bot call to explicitly specify
lspor have them be aliases, etc, but I didn't have super strong opinions either way)I don't believe this conflicts with/doubles up anything included in #210