Skip to content

fix: use wire info from original property for spread parameter matching#10123

Merged
JoshLove-msft merged 3 commits into
microsoft:mainfrom
JoshLove-msft:joshlove/spread-wire-name-cleanup
Mar 24, 2026
Merged

fix: use wire info from original property for spread parameter matching#10123
JoshLove-msft merged 3 commits into
microsoft:mainfrom
JoshLove-msft:joshlove/spread-wire-name-cleanup

Conversation

@JoshLove-msft
Copy link
Copy Markdown
Contributor

Remove name-based fallback and use original property's wire info (via OriginalName) to populate the wire name dictionary for customized properties in spread conversion.

Remove name-based fallback and use original property's wire info
(via OriginalName) to populate the wire name dictionary for customized
properties in spread conversion.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Mar 24, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 24, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-csharp@10123

commit: 66da9aa

@github-actions
Copy link
Copy Markdown
Contributor

No changes needing a change description found.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When a constructor parameter has no Property reference (custom code
constructors), resolve its wire name by looking up the matching
property in the model by parameter name.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@JoshLove-msft JoshLove-msft added this pull request to the merge queue Mar 24, 2026
Merged via the queue into microsoft:main with commit 7d5e124 Mar 24, 2026
25 checks passed
@JoshLove-msft JoshLove-msft deleted the joshlove/spread-wire-name-cleanup branch March 24, 2026 22:05
msyyc pushed a commit that referenced this pull request Apr 1, 2026
…ng (#10123)

Remove name-based fallback and use original property's wire info (via
OriginalName) to populate the wire name dictionary for customized
properties in spread conversion.

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants