[http-client-csharp] Switch scaffolding to generate .slnx instead of .sln#10234
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/cdbacd32-d08e-436b-b54f-b117d2ad257b Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
Copilot
AI
changed the title
[WIP] Switch scaffolding to create slnx instead of sln
[http-client-csharp] Switch scaffolding to generate .slnx instead of .sln
Apr 1, 2026
ArcturusZhang
requested review from
JoshLove-msft,
ShivangiReja,
christothes,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
commit: |
Contributor
|
No changes needing a change description found. |
Member
|
@copilot fix the spell check issue. |
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/2418706f-1368-4179-9e6a-d2905f32142b Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
Contributor
Author
Add a protected virtual WriteAdditionalFiles() method that subclasses can override to emit custom files (ci.yml, .targets, etc.) during new project scaffolding. Called from Execute() after solution and project files are written. Fixes #4065 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoshLove-msft
approved these changes
Apr 4, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
Fixes cross-platform compatibility issue introduced in #10234. ### Problem The \.slnx\ solution files generated by \NewProjectScaffolding\ used backslashes (\src\Package.csproj\) which is Windows-specific and may not resolve correctly on Linux/macOS. ### Changes - **\NewProjectScaffolding.cs\**: Changed \src\{0}.csproj\ to \src/{0}.csproj\ in \GetSolutionFileContent()\ - **Test projects**: Updated all 72 generated \.slnx\ files to use forward slashes - **\NewProjectScaffoldingTests.cs\**: Added test \Execute_SlnxUsesForwardSlashes\ to verify forward slashes are used in the generated content --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
msyyc
pushed a commit
that referenced
this pull request
Apr 9, 2026
Fixes cross-platform compatibility issue introduced in #10234. ### Problem The \.slnx\ solution files generated by \NewProjectScaffolding\ used backslashes (\src\Package.csproj\) which is Windows-specific and may not resolve correctly on Linux/macOS. ### Changes - **\NewProjectScaffolding.cs\**: Changed \src\{0}.csproj\ to \src/{0}.csproj\ in \GetSolutionFileContent()\ - **Test projects**: Updated all 72 generated \.slnx\ files to use forward slashes - **\NewProjectScaffoldingTests.cs\**: Added test \Execute_SlnxUsesForwardSlashes\ to verify forward slashes are used in the generated content --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4065
Fixes #10233
Per latest .NET guidelines, new projects should use the XML-based
.slnxsolution format rather than the legacy.slnformat.Changes
NewProjectScaffolding.cs: Replace.slngeneration with.slnx. The verbose GUIDs-and-config.slncontent is replaced with the minimal XML format. Cleanup inExecute()now handles both.sln(backward compat) and.slnx.CommandLineOptions.cs: Updated help text to referenceslnx..slnx.Generated
.slnxoutput: