[python] Fix test_sensitive_word failing on Windows#10300
Merged
Conversation
Replace shell-based search (powershell Select-String / grep) with pure Python pathlib.rglob + read_text. The PowerShell implementation output relative paths while the regex expected absolute paths, causing the test to always return empty results on Windows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
msyyc
added
the
emitter:client:python
msyyc
requested review from
ChenxiJiang333,
catalinaperalta,
laiapat,
lmazuel,
swathipil and
timotheeguerin
as code owners
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
All changed packages have been documented.
Show changes
|
ChenxiJiang333
approved these changes
Apr 8, 2026
commit: |
Collaborator
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_sensitive_wordintest_unbranded.pyfails on Windows CI because thecheck_sensitive_wordfunction uses PowerShellSelect-Stringwhich outputs relative paths, while the regex expects absolute paths fromfolder.as_posix(). This causes the function to always return[]on Windows.On Linux,
grepoutputs absolute paths so the test passes.Fix
Replace the platform-specific shell commands (
powershell Select-String/grep) with pure Python usingpathlib.rglob+read_text. This is: