[python] Fix @clientDefaultValue serialization regression from #10476 by Copilot · Pull Request #10546 · microsoft/typespec

Copilot · 2026-04-29T11:15:28Z

Fix follow-up for #10476: restore client default value materialization for serialization, plus a couple of regenerator-tooling changes that landed on the same branch.

Addresses review comment r3160211783 on PR #10476.

Changes

Restore default population in Model.__init__ (generator/pygen/codegen/templates/model_base.py.jinja2) so @clientDefaultValue defaults are present in _data and serialized on the wire (the _RestField.__get__ fallback for unset fields is kept intact).
Extract the shared regenerator helpers, types, constants, and spec/emitter-option tables out of eng/scripts/ci/regenerate.ts into a new eng/scripts/ci/regenerate-common.ts module so the file can be kept byte-identical with the @azure-tools/typespec-python wrapper copy (pnpm sync). Per-repo divergence (paths, emitter name, single- vs two-phase orchestration, argv/help text) stays in each repo's own regenerate.ts, which now builds a RegenerateContext and feeds it into the shared helpers.
Bump @azure-tools/azure-http-specs from 0.1.0-alpha.39 to 0.1.0-alpha.40-dev.12 in package.json

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/91e8124d-723d-42e3-a606-d2e9fa8cd443 Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

pkg-pr-new · 2026-05-06T06:40:17Z

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-python@10546

commit: 1de15e3

github-actions · 2026-05-06T06:41:22Z

All changed packages have been documented.

✅ @typespec/http-client-python

Show changes

`@typespec/http-client-python` - fix ✏️

Fix serialization regression where @clientDefaultValue defaults on model properties were no longer included in the request body. Defaults are again materialized in the model's data dictionary at construction time so they are sent on the wire, while the attribute-access fallback for unset fields is preserved.

azure-sdk · 2026-05-06T09:25:58Z

You can try these changes here

🛝 Playground	🌐 Website	🛝 VSCode Extension

iscai-msft · 2026-05-06T14:54:09Z

@copilot the changes in the pipeline setup is causing these errors

Stage CSharp_Build job DetectApiChanges depends on unknown job Build_linux_20.
Stage Java_Build job DetectApiChanges depends on unknown job Build_linux_20.
Stage Python_Build job DetectApiChanges depends on unknown job Build_linux_20.

Copilot · 2026-05-06T14:56:35Z

@copilot the changes in the pipeline setup is causing these errors

...

Reverted the unrelated pipeline changes from commit a477100 (it removed the Node 20 build jobs from eng/emitters/pipelines/templates/stages/emitter-stages.yml while detect-api-changes still has DependsOn: Build_linux_20, plus changed the test-step.yml default NodeVersion from 22.x back to 20.x). Restored both files to their pre-a477100 state in afc2db0.

iscai-msft · 2026-05-06T15:24:03Z

@copilot we still need to do 22 and up, with your last change, we got this failure on the Build_linux_20 and Build_windows_20 pipelines. maybe we should upgrade the pipelines to no longer run on the 20 version?

npm ci
npm error code EBADENGINE
npm error engine Unsupported engine
npm error engine Not compatible with your version of node/npm: @azure-tools/azure-http-specs@0.1.0-alpha.40-dev.12
npm error notsup Not compatible with your version of node/npm: @azure-tools/azure-http-specs@0.1.0-alpha.40-dev.12
npm error notsup Required: {"node":">=22.0.0"}
npm error notsup Actual: {"npm":"10.8.2","node":"v20.20.2"}
npm error A complete log of this run can be found in: /home/cloudtest/.npm/_logs/2026-05-06T15_05_06_364Z-debug-0.log
Invoke-LoggedCommand: /mnt/vss/_work/1/s/packages/http-client-python/eng/scripts/Initialize-Repository.ps1:42
Line |
42 | Invoke-LoggedCommand "npm ci"
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| ##[error]Command completed with exit code 1 (00:00:04.5497844): npm ci

##[error]PowerShell exited with code '1'.
Finishing: Run initialize script

Copilot · 2026-05-06T15:26:49Z

@copilot we still need to do 22 and up, with your last change, we got this failure on the Build_linux_20 and Build_windows_20 pipelines. maybe we should upgrade the pipelines to no longer run on t...

Agreed — upgraded the emitter pipelines to drop Node 20 entirely in db2b9af. Removed the Build_linux_20 / Build_windows_20 build jobs and the matching Node 20 test jobs from eng/emitters/pipelines/templates/stages/emitter-stages.yml, promoted the Node 22 linux build job to be the "first" job (EmitArtifacts: true, BuildArtifactName, RunSDLTools: true), updated detect-api-changes to DependsOn: Build_linux_22, and bumped the test-step.yml default NodeVersion to 22.x.

…ft/typespec into copilot/fix-issue-with-typespec

msyyc · 2026-05-08T08:57:27Z

@iscai-msft CI is fixed and pls help review again, thanks!

## Problem All Python CI runs are consistently failing with 2 test failures: - `test_put_model_property` (sync) in `test_azure_client_generator_core_client_default_value.py` - `test_put_model_property` (async) in `test_azure_client_generator_core_client_default_value_async.py` The error is: ``` Body provided doesn't match expected body: at $: Key count mismatch: expected 4 but got 1. missing: [timeout, tier, retry] ``` ## Root Cause The catalog specifies `@typespec/http-client-python: ^0.28.3`. For 0.x semver, `^0.28.3` means `>=0.28.3 <0.29.0`, so version `0.29.0` (which contains the `@clientDefaultValue` serialization fix from [microsoft/typespec#10546](microsoft/typespec#10546)) is excluded. The `azure-http-specs` mock API was updated to validate that `@clientDefaultValue` defaults are included in request bodies, but the installed generator version (0.28.3) doesn't serialize them. ## Fix - Bump catalog to `^0.29.0` - Add `@typespec/http-client-python` to `minimumReleaseAgeExclude` (0.29.0 was published <2 days ago) --------- Co-authored-by: iscai-msft <isabellavcai@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Restore client default value materialization in Model.__init__

131b844

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/91e8124d-723d-42e3-a606-d2e9fa8cd443 Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

Copilot AI assigned Copilot and msyyc Apr 29, 2026

Copilot created this pull request from a session on behalf of msyyc April 29, 2026 11:15 View session

microsoft-github-policy-service Bot added the emitter:client:python Issue for the Python client emitter: @typespec/http-client-python label Apr 29, 2026

msyyc mentioned this pull request Apr 29, 2026

[python] Fix @clientDefaultValue serialization regression from #10476 Azure/autorest.python#3469

Closed

Merge branch 'main' into copilot/fix-issue-with-typespec

8d85468

update spector dep

f56d56f

microsoft-github-policy-service Bot added the eng label May 6, 2026

msyyc marked this pull request as ready for review May 6, 2026 09:05

msyyc requested review from ChenxiJiang333, JoshLove-msft, catalinaperalta, iscai-msft, laiapat, lmazuel, msyyc, srnagar, swathipil, tadelesh and timotheeguerin as code owners May 6, 2026 09:05

iscai-msft approved these changes May 6, 2026

View reviewed changes

iscai-msft enabled auto-merge May 6, 2026 14:24

Copilot started work on behalf of iscai-msft May 6, 2026 14:54 View session

Copilot finished work on behalf of iscai-msft May 6, 2026 14:57

Copilot AI requested a review from iscai-msft May 6, 2026 14:57

Copilot started work on behalf of iscai-msft May 6, 2026 15:24 View session

Copilot finished work on behalf of iscai-msft May 6, 2026 15:27

msyyc marked this pull request as draft May 7, 2026 03:12

auto-merge was automatically disabled May 7, 2026 03:12
Pull request was converted to draft

msyyc force-pushed the copilot/fix-issue-with-typespec branch from d462382 to f56d56f Compare May 8, 2026 04:33

Merge branch 'main' into copilot/fix-issue-with-typespec

2b0fb14

msyyc marked this pull request as ready for review May 8, 2026 04:34

msyyc added 3 commits May 8, 2026 15:54

extract regenerate-common.ts

899d204

Merge branch 'python-regenerate-common' of https://github.com/microso…

79698d7

…ft/typespec into copilot/fix-issue-with-typespec

format

5632343

msyyc enabled auto-merge May 8, 2026 08:55

msyyc added 2 commits May 9, 2026 06:26

optimize

8f415a7

Merge branch 'main' into copilot/fix-issue-with-typespec

1de15e3

msyyc mentioned this pull request May 11, 2026

[python] Fix @clientDefaultValue serialization regression from #10476 Azure/autorest.python#3480

Closed

iscai-msft approved these changes May 11, 2026

View reviewed changes

msyyc added this pull request to the merge queue May 11, 2026

Merged via the queue into main with commit 902fef6 May 11, 2026
36 checks passed

msyyc deleted the copilot/fix-issue-with-typespec branch May 11, 2026 17:37

iscai-msft mentioned this pull request May 12, 2026

Bump @typespec/http-client-python catalog to ^0.29.0 Azure/typespec-azure#4413

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[python] Fix @clientDefaultValue serialization regression from #10476#10546

[python] Fix @clientDefaultValue serialization regression from #10476#10546
msyyc merged 9 commits into
mainfrom
copilot/fix-issue-with-typespec

Copilot AI commented Apr 29, 2026 •

edited by msyyc

Loading

Uh oh!

pkg-pr-new Bot commented May 6, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 6, 2026 •

edited

Loading

`@typespec/http-client-python` - fix ✏️

Uh oh!

azure-sdk commented May 6, 2026 •

edited

Loading

Uh oh!

iscai-msft commented May 6, 2026

Uh oh!

Copilot AI commented May 6, 2026

Uh oh!

iscai-msft commented May 6, 2026

Uh oh!

Copilot AI commented May 6, 2026

Uh oh!

msyyc commented May 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Apr 29, 2026 • edited by msyyc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

pkg-pr-new Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@typespec/http-client-python - fix ✏️

Uh oh!

azure-sdk commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iscai-msft commented May 6, 2026

Uh oh!

Copilot AI commented May 6, 2026

Uh oh!

iscai-msft commented May 6, 2026

Uh oh!

Copilot AI commented May 6, 2026

Uh oh!

msyyc commented May 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 29, 2026 •

edited by msyyc

Loading

pkg-pr-new Bot commented May 6, 2026 •

edited

Loading

github-actions Bot commented May 6, 2026 •

edited

Loading

`@typespec/http-client-python` - fix ✏️

azure-sdk commented May 6, 2026 •

edited

Loading