fix(http-client-python): Fix CI#10686
Merged
Merged
Conversation
Delete README.md files during baseline reset so regeneration recreates them for both azure and unbranded flavors. Extend unit test to assert README.md exists for every generated SDK package.
msyyc
requested review from
ChenxiJiang333,
catalinaperalta,
iscai-msft,
lmazuel,
swathipil,
tadelesh and
timotheeguerin
as code owners
microsoft-github-policy-service
Bot
added
the
emitter:client:python
msyyc
changed the title
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Collaborator
|
You can try these changes here
|
ChenxiJiang333
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI after Azure/azure-sdk-for-python#46881 merged.
Description
Fix CI on main branch.
The baseline reset step in
regenerate-common.tswas leaving stale (or missing) README.md files in generated SDK packages. Since the generator only writes README.md when none exists on disk (write-once), unbranded packages ended up without a README at all, and azure packages kept stale ones.Changes
eng/scripts/ci/regenerate-common.ts: After resetting the baseline, delete everyREADME.mdundertests/generated/so regeneration recreates them from the current template. Also refactored the cleanup block behind a shareddeleteIfExistshelper.tests/mock_api/shared/unittests/test_readme.py: New unit test asserting that every generated SDK package folder (bothazureandunbrandedflavors) contains aREADME.md.package.json: Bump required Node engine to>=22.