fix(http-client-csharp): declare @azure-tools/typespec-azure-core as peer dependency#10823
Merged
jorgerangel-msft merged 3 commits intoMay 28, 2026
Conversation
…peer dependency The emitter imports from @azure-tools/typespec-azure-core at runtime but previously relied on npm's flat hoisting. Under pnpm (especially with enableGlobalVirtualStore: true) and other strict resolvers the import fails. Declare it as a peerDependency alongside typespec-client-generator-core. Fixes microsoft#10802 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoshLove-msft
requested review from
ShivangiReja,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
# Conflicts: # packages/http-client-csharp/package.json
commit: |
Contributor
|
No changes needing a change description found. |
jorgerangel-msft
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10802
The C# emitter imports from
@azure-tools/typespec-azure-coreat runtime (inemitter/src/type/operation-final-state-via.ts), but it was only listed underdevDependencies. npm's flat hoisting let this resolve "by accident" in standard installs, but pnpm withenableGlobalVirtualStore: true(and other strict resolvers like Yarn PnP) correctly fail to resolve it.This PR declares
@azure-tools/typespec-azure-coreas apeerDependencyalongside@azure-tools/typespec-client-generator-core, using a matching version range.Note: the companion issue in #10802 about
@azure-tools/typespec-azure-coremissing@typespec/versioninglives in the azure/typespec-azure repo and needs a separate PR there.