fix: resolve comment end confusion inside inline JavaScript (#151)#245
Open
maruthang wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: resolve comment end confusion inside inline JavaScript (#151)#245maruthang wants to merge 1 commit intomicrosoft:mainfrom
maruthang wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…t#151) Add convertScriptContentToJavaScript utility that uses depth tracking to only replace paired <!-- / --> markers with JS block comments, leaving unpaired --> (e.g. inside JS block comments) untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #151
Bug:
-->inside JavaScript block comments within inline<script>tags was being incorrectly replaced, breaking intellisense.Root Cause: The comment marker replacement logic did not track whether
<!--/-->markers were actually paired, so stray-->tokens (e.g., inside/* --> */) were incorrectly converted to*/.Fix: Added a new
convertScriptContentToJavaScriptutility function that uses depth tracking to only replace matched<!--/-->pairs with/*/*/. Unpaired-->markers are left untouched. The function is exported from the main entry point for consumers.Changes
src/parser/htmlScanner.ts: AddedconvertScriptContentToJavaScriptfunction with depth-based pair matchingsrc/htmlLanguageService.ts: Re-exported the new function from the public API surfacesrc/test/scanner.test.ts: Added 8 regression tests covering paired markers, unpaired-->, nested markers, empty content, and edge casesTesting
src/test/scanner.test.tsverifying correct handling of paired and unpaired HTML comment markers