Skip to content

Conversation

@Benjin
Copy link
Contributor

@Benjin Benjin commented Nov 7, 2025

Pull Request Template – vscode-mssql

Description

Moving all remaining asserts to fluent-style expect(x).to.be(y) where possible.

TODO:

  • add warning rule when attempting to import assert library

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 58.83% 58.83% ⚪ 0.00%
VSIX Size 5209 KB 5209 KB ⚪ 0 KB ( 0% )
Webview Bundle Size 5216 KB 5216 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.76%. Comparing base (0932470) to head (096e999).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #20490   +/-   ##
=======================================
  Coverage   56.76%   56.76%           
=======================================
  Files         205      205           
  Lines       18369    18369           
  Branches     1164     1164           
=======================================
  Hits        10428    10428           
  Misses       7941     7941           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants