Exclude terminal editors from recently closed editors history

[SalerSimo]

Fix #280043

Now historyService.recentlyClosedEditors will not track terminal editors.

[vs-code-engineering]

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

• src/vs/workbench/common/editor/editorInput.ts
• src/vs/workbench/services/history/browser/historyService.ts

[bpasero]

Thanks, I think this can go in.

Usually even a terminal editor should be supporting re-open, I am not sure why it would not.

[SalerSimo]

I investigated further, and the problem is this line: when creating a new editor from a resource that isn’t linked to any active terminal instance, it throws a timeout error.

vscode/src/vs/workbench/contrib/terminal/browser/terminalMainContribution.ts

Line 107 in b3e4c3e

const attachPersistentProcess = await primaryBackend.requestDetachInstance(terminalIdentifier.workspaceId, terminalIdentifier.instanceId);