Fix chat placeholder rotation during dictation - #327662
Open
meganrogge wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes conflicts between rotating chat prompts and dictation-owned placeholders.
Changes:
- Pauses rotation when another feature changes the placeholder.
- Restricts shimmer animation to rotation updates.
- Hides/restores placeholders across dictation and adds regression tests.
Show a summary per file
| File | Description |
|---|---|
chatInputPlaceholderRotation.ts |
Adds placeholder ownership and animation controls. |
dictationSession.ts |
Manages placeholders throughout dictation. |
chatInputPlaceholderRotation.test.ts |
Tests placeholder ownership. |
dictationSession.test.ts |
Tests dictation placeholder lifecycle. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Medium
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Review details
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPlaceholderRotation.ts:76
- After a slow microphone acquisition, this guard can pause rotation permanently after dictation ends.
startDictationsnapshots the placeholder before awaiting microphone/backend setup, while rotation remains active during acquisition; if a tick advances the prompt, dictation later restores the older snapshot, which no longer equalsexpectedPlaceholder, so every future tick returns here. Capture the placeholder when dictation first takes ownership (or add an explicit pause/resume handoff), and cover acquisition spanning a rotation interval.
if (editor.getOption(EditorOption.placeholder) !== expectedPlaceholder) {
return;
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Medium
meganrogge
enabled auto-merge (squash)
July 27, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-internalbacklog#8615
Summary
Listening…placeholder