Suppress unnecessary error log for ERROR_NOT_SUPPORTED cases

[bobsira]

This pull request introduces targeted improvements to error logging in the LogFileMonitor component. The main change is the suppression of log messages for the benign ERROR_NOT_SUPPORTED error, which helps reduce unnecessary log noise while still capturing actionable errors.

Error logging improvements:

• Suppressed logging of ERROR_NOT_SUPPORTED when failing to open log files in InitializeDirectoryChangeEventsQueue() to avoid log pollution from benign errors. [1] [2]
• Suppressed logging of ERROR_NOT_SUPPORTED when failing to query file ID in LogFileAddEventHandler() for the same reason, ensuring only actionable errors are logged.

[mloskot]

@bobsira I think similar workaround is needed here

windows-container-tools/LogMonitor/src/LogMonitor/LogFileMonitor.cpp

Lines 1082 to 1088 in 09983f6

	logWriter.TraceError(
	Utility::FormatString(
	L"Error in log file monitor. Failed to query file ID. File: %ws. Error: %d",
	fullLongPath.c_str(),
	status
	).c_str()
	);

I'm testing your LogMonitor.exe build you linked in #214 (comment) and

The waitInSeconds: 10 does not seem to help delay the files query in this particular case.

My LogMonitorConfig.json is this

{
  "LogConfig": {
    "sources": [
      {
        "includeSubdirectories": false,
        "filter": "*.log",
        "directory": "C:\\Logs",
        "waitInSeconds": 10,
        "type": "File",
        "includeFileNames": true
      }
    ]
  }
}

The fix for ordering of the waitInSeconds seem to work.

[bobsira]

@mloskot please confirm if the issue still exists in this binary -> https://minikubevhdimagebuider.blob.core.windows.net/versions/LogMonitor.exe

It has the change you've suggested. if it's there we can move this fix to a different PR and let this handle the parser fix

[mloskot]

@bobsira Hmm, I've just tested LogMonitor.exe from that URL

Invoke-WebRequest -Uri 'https://minikubevhdimagebuider.blob.core.windows.net/versions/LogMonitor.exe' -OutFile C:/LogMonitor.exe -UseBasicParsing

and this version is reported inside the container - am I using the right custom ad-hoc build of yours?

but I can't see any difference

Here is my config inside the container

and logs location

[bobsira]

Hmmm, strange that should be the binary with the change. I'll go ahead and split the PR for now. I have a feeling this issue might be coming from another place in the code as well so let's have it addressed in a different PR.

[mloskot]

Good idea. Let's take baby steps. The overall direction seems fine though 😊

[mloskot]

@bobsira Any update on this?

[mloskot]

@bobsira @CharityKathure @profnandaa Any chance to get this merged and released?

[bobsira]

@bobsira @CharityKathure @profnandaa Any chance to get this merged and released?

@mloskot Charity and Nandaa are not working on Log Monitor anymore. I'll revisit this issue this week!

[bobsira]

@mloskot I'll merge this and we will have it in the next release.