feat(cargo-wdk): support hyphen-prefixed signtool args - #737
Open
Shravan Vasista (svasista-ms) wants to merge 2 commits into
Open
feat(cargo-wdk): support hyphen-prefixed signtool args#737Shravan Vasista (svasista-ms) wants to merge 2 commits into
Shravan Vasista (svasista-ms) wants to merge 2 commits into
Conversation
…nd add mixed `-`/`/` coverage.
Copilot started reviewing on behalf of
Shravan Vasista (svasista-ms)
September 11, 2026 06:11
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Hyphen-prefixed password arguments are not currently redacted from logs and error messages.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds support for hyphen-prefixed signtool arguments and optional passthrough signing arguments.
Changes:
- Enables
--prefixed--signtool-argsvalues. - Changes signing arguments to
Option<Vec<String>>. - Updates unit and integration test coverage.
File summaries
| File | Description |
|---|---|
crates/cargo-wdk/tests/build_command_test.rs |
Tests hyphen-prefixed signing arguments. |
crates/cargo-wdk/src/cli.rs |
Parses hyphen-prefixed signing arguments. |
crates/cargo-wdk/src/actions/build/tests.rs |
Updates signing test fixtures. |
crates/cargo-wdk/src/actions/build/package_task.rs |
Handles optional signing arguments. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
- Coverage 78.52% 78.51% -0.01%
==========================================
Files 30 30
Lines 7105 7103 -2
Branches 7105 7103 -2
==========================================
- Hits 5579 5577 -2
Misses 1407 1407
Partials 119 119 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Copilot started reviewing on behalf of
Shravan Vasista (svasista-ms)
September 11, 2026 06:46
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for hyphen prefixed
--signtool-argsvalues. For e.g.-s WDRCustomTestStore /n WDRCustomTestCert -fd SHA256.Signtoolsupports both-and/prefixed arguments. Butcargo-wdkcurrently does not support-prefixed args forsigntool-args. In this PR, this support is added via theallow_hyphen_valuesattribute onsigntool_argsfield. It also makes the fieldOption<Vec<String>>similar to other passthrough args.