Tag CPython wheels as abi3 (cp310-abi3); release 3.7.1#65
Merged
Conversation
The extension module has always been compiled against the stable ABI (py_limited_api in eparser_build.py produces _eparser.abi3.so), but bdist_wheel was never told, so the wheels were tagged cp3X-cp3X and only served the exact Python version they were built with - all other CPython versions silently fell back to sdist source builds. Pass the py_limited_api option to bdist_wheel via setup() (on CPython only; PyPy has no stable ABI), so a single cp310-abi3 wheel now serves all CPython versions >= 3.10. Verified locally: a wheel built under Python 3.13 installs and parses correctly on both 3.10 and 3.14. Also bump the extension's limited API target from cp39 to cp310 to match the supported floor. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The extension module has always been compiled against the stable ABI (the
py_limited_apiflag ineparser_build.pyproduces_eparser.abi3.so), butbdist_wheelwas never informed, so published wheels were taggedcp3X-cp3Xand only served the exact Python version they were built with — every other CPython version silently fell back to building from the sdist (observed for 3.7.0 and all earlier releases; e.g. 3.6.2 shipscp39-cp39wheels).This PR passes the
py_limited_apioption tobdist_wheelviasetup()(CPython only — PyPy has no stable ABI), so a singlecp310-abi3wheel serves all CPython versions >= 3.10. The extension's limited API target is bumped fromcp39tocp310to match the supported floor, and the version is bumped to 3.7.1.Test plan
reynir-3.7.1-cp310-abi3-linux_x86_64.whl🤖 Generated with Claude Code