Maintenance#6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This maintenance PR updates the project to support Python 3.14, modernizes the development toolchain by switching from Black to Ruff for linting and formatting, and includes various code quality improvements.
- Added Python 3.14 support in project configuration and CI matrix
- Switched from Black to Ruff for code formatting and linting
- Fixed linting issues and improved code formatting consistency
- Added explicit package exports via
__all__declarations
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/rmh.py | Updated copyright, reformatted imports, fixed linting issues, and removed unused imports |
| src/icegrams/trie_build.py | Updated copyright dates |
| src/icegrams/ngrams.py | Updated copyright, removed unnecessary parentheses, and cleaned up formatting |
| src/icegrams/init.py | Updated copyright and added explicit __all__ exports |
| pyproject.toml | Added Python 3.14 support and removed Black configuration |
| .github/workflows/python-package.yml | Updated CI matrix to include Python 3.14 beta and additional PyPy versions |
Comments suppressed due to low confidence (1)
.github/workflows/python-package.yml:15
- The Python version '3.14.0-beta.4' may not exist or be available. Python 3.14 is not yet released and beta versions may have different naming conventions. Consider using a more general version specifier or verify the exact beta version available.
python-version: ["3.9", "3.13", "3.14.0-beta.4", "pypy-3.9", "pypy-3.10", "pypy-3.11"]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB: More to come, but serious changes shouldn't be lost in the linter reformatting