fix(contracts): embed nullifiers vector in Circle state to prevent archival replays (#254) - #1
Closed
midexol wants to merge 1 commit into
Closed
fix(contracts): embed nullifiers vector in Circle state to prevent archival replays (#254)#1midexol wants to merge 1 commit into
midexol wants to merge 1 commit into
Conversation
Owner
Author
|
Closing PR created in fork repo; official PR opened upstream at crackedstudio#360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves crackedstudio#254
Previously, the contract stored nullifiers as standalone persistent storage entries (\DataKey::Nullifier(circle_id, nullifier_hash)). While \Circle\ persistent entries are re-extended on every \und\ or \claim, write-once nullifier entries were only extended once at creation time (\LEDGER_EXTEND_TO = 500_000\ ledgers). Once archived, \env.storage().persistent().has(&nullifier_key)\ would return \alse, opening a security vulnerability where a claim could be replayed after TTL expiry.
Solution
ullifier_fence_survives_ttl_expiry\ test in \contracts/sharibo/src/test.rs\ to verify the fence after ledger advancement, and updated \docs/threat-model.md.