-
Notifications
You must be signed in to change notification settings - Fork 43
feat(web): обща маркирана стойност на договорите със сигнали за риск (#218) #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DiyanaDimitrova
wants to merge
7
commits into
midt-bg:main
Choose a base branch
from
DiyanaDimitrova:feat/homepage-flagged-value
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b6b4fc5
feat(web): homepage flagged-value + risk-signal breakdown (#218)
DiyanaDimitrova ee38c88
refactor(web): address #218 review + reuse single-offer components
DiyanaDimitrova 6b69786
fix(web): address government security/GDPR/a11y review of #218
DiyanaDimitrova 40920ab
fix(web): address #236 review — high_markup parity, label typing, top…
DiyanaDimitrova 5e21fad
fix(db): harden flagged-homepage PII suppression and type-group links
DiyanaDimitrova 0b42213
fix(db): address #236 review — case-robust ЕТ match, document NULL/pe…
DiyanaDimitrova f0f415f
Merge remote-tracking branch 'upstream/main' into feat/homepage-flagg…
DiyanaDimitrova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow-listът тук (
KNOWN_TYPES = AUTHORITY_TYPE_GROUPS = Object.keys(TYPE_LABELS)) е коректна и добра защита срещу cache-cardinality/DoS. Една бележка за консистентност: линковете на началната страница по „тип институция" се строят отa.type_groupв БД (getFlaggedValue.byAuthorityType). Ако някога в БД попаднеtype_groupизвън седемте канонични кофи вTYPE_LABELS, съответният линк?type=<x>ще бъде отхвърлен тук и изгледът тихо ще покаже ВСИЧКИ маркирани договори вместо конкретния тип (разминаване етикет↔резултат). Днес наборът е затворен и е ОК; струва си малък guard/тест, който да гарантира, че всяка стойностtype_groupот разбивката е ∈AUTHORITY_TYPE_GROUPS. Не блокиращо.