Skip to content

Set GOTOOLCHAIN=go1.25.7 in konflux.Dockerfile #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kaovilai wants to merge 1 commit into from
+1 −0
Closed

Set GOTOOLCHAIN=go1.25.7 in konflux.Dockerfile #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions konflux.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# into the build context before this Dockerfile runs.

FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_golang_1.25 AS builder
ENV GOTOOLCHAIN=go1.25.7
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting GOTOOLCHAIN=go1.25.7 in a hermetic Konflux build can become brittle: if/when the builder image is updated to ship a different patch (e.g. go1.25.8), go may try to switch to/go-download 1.25.7 (which likely fails in a hermetic environment). Consider using GOTOOLCHAIN=local to force using the toolchain already present in the image (still bypassing the toolchain go1.25.8 directive), or add an explicit note/TODO describing when/how this pin should be removed/updated alongside the builder image tag.

Suggested change
ENV GOTOOLCHAIN=go1.25.7
ENV GOTOOLCHAIN=local

Copilot uses AI. Check for mistakes.

COPY . /workspace
WORKDIR /workspace
Expand Down
Loading