Catches exception thrown by Ember 2.0 when no item is selected #91#106
Open
ninoreiter wants to merge 1 commit intomiguelcobain:masterfrom
ninoreiter:master
Open
Catches exception thrown by Ember 2.0 when no item is selected #91#106ninoreiter wants to merge 1 commit intomiguelcobain:masterfrom ninoreiter:master
ninoreiter wants to merge 1 commit intomiguelcobain:masterfrom
ninoreiter:master
Conversation
Owner
|
@ninoraubaum I think that testing _get(obj, keyName) {
if (obj) { return get(obj, keyName); }
else { return undefined; }
}Do you agree, and if so, would you mind updating the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ember 2.0 changed the behavior of Ember.get(obj, keyName). If obj is undefined or null, older versions of Ember return undefined. With the changes of Ember 2.0 this behavior changed and an exception is been thrown. This exception can be reproduced when no item is selected (selection = null).
The changes restore the old behavior of Ember.get by wrapping it in the method _getWithExceptionHandling.
See issue #91