Open
Conversation
migueleliasweb
force-pushed
the
enabling-gh-actions
branch
from
0a775b3 to
a372110
Compare
planeiii-te
suggested changes
Dec 8, 2021
Comment on lines
+7
to
+8
| go-version: [1.16.x] | ||
| platform: [ubuntu-latest] |
There was a problem hiding this comment.
This change will make it easier to add additional versions and platforms in the future with minimal diffs.
Suggested change
| go-version: [1.16.x] | |
| platform: [ubuntu-latest] | |
| go-version: | |
| - 1.16 | |
| platform: | |
| - ubuntu-latest |
|
|
||
| - uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: 1.16 |
There was a problem hiding this comment.
Make use of the matrix version:
Suggested change
| go-version: 1.16 | |
| go-version: ${{ matrix.go-version }} |
|
Is this PR still a thing? I'd like to understand how current Go versions are supported. |
Owner
Author
Hi @kwk , yeah kinda. I was quickly testing the github actions integration but never really got around to fully implement it. From what I know, I don't think this repo has any limitations on any specific Go version. If you want to contribute for the GH actions setup, please feel free to do so 😃 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.