🎨 Palette: [UX improvement] Expand shortcut folder tooltip hit area - #438
🎨 Palette: [UX improvement] Expand shortcut folder tooltip hit area#438google-labs-jules[bot] wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Code Review — PR #438What this PR does: Moves Overall assessment: The change is minimal, compiles correctly, and achieves its stated goal. One issue to address: Because The original scoping — tooltip only on the @jules please address the issues noted above |
Thank you for the review. I have updated the XAML structure as requested: |
| <Grid Background="Transparent" ToolTipService.ToolTip="{x:Bind Path}" Padding="0,2,0,2"> | ||
| <TextBlock Text="{x:Bind Path}" FontSize="12" Foreground="{ThemeResource TextFillColorSecondaryBrush}" | ||
| TextTrimming="CharacterEllipsis" /> | ||
| </Grid> |
There was a problem hiding this comment.
Grid is a multi-child layout panel; Border is the idiomatic single-child decorator for adding padding/background. Functionally identical here, but Border is lighter and makes the intent clearer.
| <Grid Background="Transparent" ToolTipService.ToolTip="{x:Bind Path}" Padding="0,2,0,2"> | |
| <TextBlock Text="{x:Bind Path}" FontSize="12" Foreground="{ThemeResource TextFillColorSecondaryBrush}" | |
| TextTrimming="CharacterEllipsis" /> | |
| </Grid> | |
| <Border Background="Transparent" ToolTipService.ToolTip="{x:Bind Path}" Padding="0,2,0,2"> | |
| <TextBlock Text="{x:Bind Path}" FontSize="12" Foreground="{ThemeResource TextFillColorSecondaryBrush}" | |
| TextTrimming="CharacterEllipsis" /> | |
| </Border> |
Code ReviewWhat this PR does: Expands the tooltip hit area for shortcut folder path rows in the Settings window. The path Thread resolution: The previous unresolved thread raised the concern that the tooltip was on the parent Overall assessment: The approach is correct and the targeted fix is sound. One non-blocking suggestion: Using No blocking issues. |
💡 What: Moved the ToolTipService.ToolTip from the inner TextBlock to the parent StackPanel in SettingsWindow.xaml and added Background='Transparent'.
🎯 Why: Increases the hover target area for the folder path tooltip, so the tooltip displays when the user hovers over any part of the folder name or path list item.
♿ Accessibility: Improves usability for users with motor difficulties by expanding the interactable hit area for the tooltip.
PR created automatically by Jules for task 4167422764312012505 started by @mikekthx