fix: clippy collapsible_if and rustfmt trailing comma#78
Merged
Conversation
- Bump version to 0.2.2-alpha. - CI green-up: collapse the nested if/if let in src/api/ai.rs (introduced with Azure OpenAI support) into a let-chain so cargo clippy --all-targets --all-features stops failing under RUSTFLAGS=-Dwarnings; drop the trailing comma after the Discord match arm in src/executor/notifications.rs so cargo fmt --check passes. - Refresh docs to cover everything merged since v0.2.1-alpha: Azure OpenAI / AI Foundry (custom base URL + api-version), the max_completion_tokens switch for gpt-5/o-series, the Discord webhook format, the Playwright e2e suite, and the dependabot bumps. README adds Azure to the AI provider list and Discord to the notifications list. DEPLOYMENT documents KRONFORCE_AI_BASE_URL and KRONFORCE_AI_API_VERSION. TESTING points at e2e/README.md. - perf(db): new migration 0022_execution_perf_indexes.sql adds idx_executions_created_at and idx_executions_finished_at. The Runs page orders by created_at and the periodic retention purger filters on finished_at, but neither column was indexed. At ~84k rows on the demo deployment this means a full table sort on every Runs page load and a full scan on every purge tick. Query plans verified locally to switch to index scans for both.
mikemiles-dev
force-pushed
the
fix/clippy-collapsible-if-azure-endpoint
branch
from
62d60c7 to
635aba7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI runs clippy with -Dwarnings and rejects the collapsible_if introduced in the Azure OpenAI endpoint change, and the trailing comma after a match arm block introduced in the Discord webhook format change.