Improve performance#296
Open
bmjask wants to merge 2 commits into
Open
Conversation
# Conflicts: # benches/hot_path_bench.rs # src/variable_versions/field_value.rs # src/variable_versions/v9/parser.rs
There was a problem hiding this comment.
Pull request overview
This PR adds a new Rust example intended to measure NetflowParser::parse_bytes hot-path performance for NetFlow v9 and IPFIX, plus a minor Cargo.toml cleanup.
Changes:
- Add
examples/perf_hot_path.rs, a CLI micro-benchmark that generates template/data packets and times repeated parsing. - Normalize formatting for the
etherparsedependency line inCargo.toml.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/perf_hot_path.rs | Adds a performance-focused example that generates v9/IPFIX packets and benchmarks parsing throughput. |
| Cargo.toml | Removes trailing whitespace / normalizes the etherparse dependency line formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+274
to
+277
| let (template, data) = match protocol.as_str() { | ||
| "v9" => (v9_template_packet(), v9_data_packet(flows)), | ||
| "ipfix" => (ipfix_template_packet(), ipfix_data_packet(flows)), | ||
| _ => { |
Owner
|
Can you add a description? Is this just a new benchmark? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.