Skip to content

docs: Add AI Coding Assistants documentation#217

Open
Netplayz wants to merge 22 commits into
mikeywhiston:Developmentfrom
Netplayz:Development
Open

docs: Add AI Coding Assistants documentation#217
Netplayz wants to merge 22 commits into
mikeywhiston:Developmentfrom
Netplayz:Development

Conversation

@Netplayz
Copy link
Copy Markdown
Contributor

@Netplayz Netplayz commented Apr 9, 2026

Add guidance for AI assistants and developers using AI tools for ERM
contributions.

documentation/coding-assistants.md is for guiding AI assistants
on licensing, Signed-off-by requirements, and attribution format. The
README.md points AI tools to this documentation so they wont miss it.

Signed,
Netbyte

edit: PR message was taken and edited from torvalds/linux@78d979d

Copy link
Copy Markdown
Collaborator

@ar-cyber ar-cyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Just some branding issues.

Comment thread documentation/coding-assistants.md Outdated
# AI Coding Assistants

This document provides guidance for AI tools and developers using AI
assistance when contributing to the ERM bot.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ERM

Comment thread documentation/coding-assistants.md Outdated
This document provides guidance for AI tools and developers using AI
assistance when contributing to the ERM bot.

AI tools helping with ERM bot development should follow the standard
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. Just ERM instead of ERM bot

@Netplayz
Copy link
Copy Markdown
Contributor Author

Netplayz commented Apr 9, 2026

Fixed

Copy link
Copy Markdown
Collaborator

@ar-cyber ar-cyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one grammatical error. Changes look good tho.

Comment thread documentation/coding-assistants.md Outdated
@Netplayz
Copy link
Copy Markdown
Contributor Author

Netplayz commented Apr 9, 2026

Where's the error

Co-authored-by: Andrew R <25roband@cbc.sa.edu.au>
Copy link
Copy Markdown
Collaborator

@ar-cyber ar-cyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Just need unknown to merge (or mikey)

CC: @UnknownGamerz6996 @mikeywhiston

@Netplayz
Copy link
Copy Markdown
Contributor Author

Netplayz commented Apr 9, 2026

Found it, I'm not use to the github UI on mobile.

@Netplayz
Copy link
Copy Markdown
Contributor Author

Netplayz commented Apr 9, 2026

All good. Just need unknown to merge (or mikey)

CC: @UnknownGamerz6996 @mikeywhiston

👍

@ar-cyber
Copy link
Copy Markdown
Collaborator

ar-cyber commented Apr 9, 2026

Found it, I'm not use to the github UI on mobile.

I hate it on my phone. I literally get out my laptop on the bus just to review prs.

@Netplayz
Copy link
Copy Markdown
Contributor Author

Netplayz commented Apr 9, 2026

I'm in the car getting pizza and fixing these issues lol

@Netplayz
Copy link
Copy Markdown
Contributor Author

Netplayz commented Apr 9, 2026

Expect a few more PRs about documentation on modules

@Netplayz
Copy link
Copy Markdown
Contributor Author

Netplayz commented Apr 9, 2026

Unknown complained about undocumented code in VC a while back that's why I thought of it.

@Netplayz
Copy link
Copy Markdown
Contributor Author

@UnknownGamerz6996 I have more documentation I need to put in.

@Netplayz
Copy link
Copy Markdown
Contributor Author

I am gonna put it in a different PR but I cant open a PR until you approve this one.

@ar-cyber
Copy link
Copy Markdown
Collaborator

Just made some changes to the contribution guidelines as some stuff isn't required.

Copy link
Copy Markdown
Collaborator

@ar-cyber ar-cyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some things to change

Comment thread readme.md Outdated
Comment thread documentation/setup.md
Comment thread documentation/setup.md Outdated
or MongoDB `ObjectId` values depending on the collection.
- The `Document` base class in `utils/mongo.py` provides all standard
async CRUD methods. Use those rather than accessing `bot.db` directly
with raw pymongo calls.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raw pymongo calls are required as the document class doesn't expose everything. e.g. find_one, find, and aggregate may be needed but aren't exposed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really necessary to remove.

Comment thread documentation/architecture.md
Comment thread documentation/setup.md Outdated
@ar-cyber ar-cyber added documentation Improvements or additions to documentation Under Review The ERM Team is Reviewing your Pull Request labels Apr 26, 2026
@Netplayz Netplayz requested a review from ar-cyber April 26, 2026 03:01
@Netplayz
Copy link
Copy Markdown
Contributor Author

@ar-cyber review requested

@ar-cyber
Copy link
Copy Markdown
Collaborator

@ar-cyber review requested

No changes have been made.

Netplayz and others added 6 commits April 25, 2026 23:08
Co-authored-by: Andrew R <loafing@sockycat.net>
Co-authored-by: Andrew R <loafing@sockycat.net>
Co-authored-by: Andrew R <loafing@sockycat.net>
Co-authored-by: Andrew R <loafing@sockycat.net>
Copy link
Copy Markdown
Collaborator

@ar-cyber ar-cyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just these changes

Comment thread documentation/setup.md

When inviting the bot, the following are required:

- `Bot`
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot doesn't have a capital B - it's a scope, like applications.commands

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesnt really matter

Comment thread readme.md Outdated
Comment on lines +62 to +72
- Python 3.12. Match the style of the surrounding code.
- All database calls must be `async`. Use `await` throughout — do not
use blocking pymongo calls.
- Ensure the use of the `Document` class whenever accessing different collections.
- Do not create Documents in commands, define them on the instance method `self` in the setup hook.
- Use `discord.ext.tasks.loop` for new background tasks.
- New interactive Discord flows must have their own UI file in `ui/`. Do not add new enties to `menus.py`.
- Use `utils/constants.py` for shared colour values (`BLANK_COLOR`,
`GREEN_COLOR`, `RED_COLOR`) rather than hardcoding hex values.
- Use `decouple.config()` for all environment variable access.
- Do not use inline ENV comments
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread documentation/architecture.md Outdated
| `statistics_check` | Periodic | Updates analytics records |
| `tempban_checks` | Periodic | Lifts expired temporary bans |
| `check_whitelisted_car` | Periodic | Enforces whitelisted vehicle rules in-game |
| `change_status` | Periodic | Rotates the bot's Discord presence status |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runs once

| `ERLC` | ER:LC in-game integration (bans, kicks, player lookup) |
| `GameLogging` | In-game event log forwarding to Discord channels |
| `Infractions` | Staff infraction tracking and management |
| `Jishaku` | Developer/debug REPL (conditionally loaded) |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not conditionally loaded

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to be fixed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "not conditionally loaded"

Co-authored-by: Andrew R <loafing@sockycat.net>
@Netplayz
Copy link
Copy Markdown
Contributor Author

I am on my phone I will do these in a minute

@ar-cyber
Copy link
Copy Markdown
Collaborator

I am on my phone I will do these in a minute

all good. no rush

@Netplayz
Copy link
Copy Markdown
Contributor Author

@ar-cyber can you make edit requests rq since I'm far from my laptop

@ar-cyber
Copy link
Copy Markdown
Collaborator

i can't atm

@ar-cyber
Copy link
Copy Markdown
Collaborator

ar-cyber commented May 4, 2026

@Netplayz can you just finish my feedback

@Netplayz
Copy link
Copy Markdown
Contributor Author

Netplayz commented May 4, 2026 via email

@ar-cyber
Copy link
Copy Markdown
Collaborator

ar-cyber commented May 4, 2026

Hi Andrew, I’m currently focused on a major project that requires my full attention, so I won't be able to address that feedback right now. Best regards, Netbyte

On Mon, May 4, 2026 at 12:29 AM Andrew R @.> wrote: ar-cyber left a comment (mikeywhiston/ERM#217) <#217 (comment)> @Netplayz https://github.com/Netplayz can you just finish my feedback — Reply to this email directly, view it on GitHub <#217 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQUG6FRRYKWVRNUS43XESC34ZAMCLAVCNFSM6AAAAACXR5USHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGNRYGI2DKOBSGM . You are receiving this because you were mentioned.Message ID: @.>

That's all good.

Netplayz added 2 commits May 12, 2026 20:01
Removed duplicate warning about not using this file for new views.
Copy link
Copy Markdown
Contributor Author

@Netplayz Netplayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting review.

@Netplayz Netplayz requested a review from ar-cyber May 13, 2026 00:05
Copy link
Copy Markdown
Collaborator

@ar-cyber ar-cyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needs a couple fixes

Comment thread documentation/architecture.md Outdated
| `ERLC` | ER:LC in-game integration (bans, kicks, player lookup) |
| `GameLogging` | In-game event log forwarding to Discord channels |
| `Infractions` | Staff infraction tracking and management |
| `Jishaku` | Developer/debug REPL (conditionally loaded) |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to be fixed

Co-authored-by: Andrew R <loafing@sockycat.net>
Comment thread documentation/setup.md
- `PRODUCTION_BOT_TOKEN` — Bot token for the production environment
- `DEVELOPMENT_BOT_TOKEN` — Bot token for the development environment
- `DEVELOPMENT_BOT_TOKEN` — Bot token for the development environment
- `CUSTOM_GUILD_ID` must stay 0 in order to be used in other servers. If set to a specific server the bot cannot operate in other servers.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be set to 0 regardless of usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Under Review The ERM Team is Reviewing your Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants