Normalize scalar types for prior, likelihood, and posterior in Link#69
Open
marie-cloet2000 wants to merge 1 commit intomikkelbue:mainfrom
Open
Normalize scalar types for prior, likelihood, and posterior in Link#69marie-cloet2000 wants to merge 1 commit intomikkelbue:mainfrom
Link#69marie-cloet2000 wants to merge 1 commit intomikkelbue:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68
Summary
This PR normalizes the types of
priorandlikelihoodin theLinkclass to ensure they are always scalar values. This prevents downstream failures in diagnostics (specificallyto_inference_data) caused by mixing Python scalarsand 1‑element NumPy arrays.
Motivation
While
Link.prior,Link.likelihood, andLink.posteriorare documented as floats, in practiceprior(and thereforeposterior) can be passed in as a 1‑element NumPy array depending on the prior implementation. This leads toinconsistent types:
prior:np.ndarraywith shape(1,)likelihood: Pythonfloatposterior:np.ndarraywith shape(1,)When diagnostics attempt to stack these values into a NumPy array, this results in a
ValueErrordue to inhomogeneous shapes.Changes
priorandlikelihoodto scalar values inLink.__init__.item()) to avoid deprecation warningsImpact
to_inference_datarobust to different prior implementationsNotes
I used Microsoft Copilot for suggestions on how to improve the code and to write this PR message.