Open
Conversation
StevenClontz
commented
Dec 12, 2024
Owner
|
Interesting! Not saying this is bad – would |
Contributor
Author
Exactly. Feedback on my app was that users would click my sign in button, enter their code, and then have trouble navigating back to the page they were at when they originally tried to log in. So now my buttons have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the behavior of
save_passwordless_redirect_location!to support saving custom URLs, and uses it to support implementingredirect_toparameter on the#newaction. Example usage:Otherwise, I don't believe there's a solution for developers to manually set a redirect location, other than something like
session[redirect_session_key(User)] = params[:redirect_to]directly (which I currently have running as abefore_actiononsession#new).