Skip to content

fix: improve analytics observability for retention debugging #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidenybai merged 3 commits into from
Apr 5, 2026
Merged

fix: improve analytics observability for retention debugging #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e3a625
fix: improve analytics observability for retention debugging
NisargIO Apr 5, 2026
f750345
Apply suggestion from @cubic-dev-ai[bot]
NisargIO Apr 5, 2026
bdfaf7f
fix: refine error handling in executeFn for improved type safety
NisargIO Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .cursor/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{

@vercel vercel Bot Apr 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDE-specific settings file (.cursor/settings.json) was committed to the repository when it should only be in .gitignore

Fix on Vercel

"plugins": {
"posthog": {

@aidenybai aidenybai Apr 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? do u wanna comit this

"enabled": true
}
}
}

@cursor cursor Bot Apr 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor IDE settings file accidentally committed to repository

Low Severity

The .cursor/settings.json file enables the Cursor IDE PostHog telemetry plugin. This is IDE-specific configuration unrelated to the PR's application analytics improvements. The .gitignore already covers .cursor/plans but not this file, suggesting it was unintentionally included alongside the analytics changes.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6e3a625. Configure here.

12 changes: 9 additions & 3 deletions apps/cli/src/components/screens/cookie-sync-confirm-screen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,16 @@ export const CookieSyncConfirmScreen = ({
const confirm = () => {
const keys = [...selectedKeys];
setCookieBrowserKeys(keys);
trackEvent("cookies:browser_selection", {
selected_count: keys.length,
browsers: keys.join(","),
trackEvent("cookies:sync_choice", {
choice: keys.length > 0 ? "use_cookies" : "skip_cookies",
});
if (keys.length > 0) {
trackEvent("cookies:browser_selection", {
selected_count: keys.length,
browsers: keys.join(","),
});
trackEvent("cookies:toggled", { enabled: true });
}
if (changesFor && instruction) {
setScreen(
screenForTestingOrPortPicker({
Expand Down
1 change: 1 addition & 0 deletions apps/cli/src/components/screens/main-menu-screen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ export const MainMenu = ({ gitState }: MainMenuProps) => {
if (cookieBrowserKeys.length > 0) {
clearCookieBrowserKeys();
trackEvent("cookies:cleared");
trackEvent("cookies:toggled", { enabled: false });
} else {
setScreen(Screen.CookieSyncConfirm({}));
}
Expand Down
11 changes: 10 additions & 1 deletion apps/cli/src/data/execution-atom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,16 @@ export const executeFn = cliAtomRuntime.fn<ExecuteInput>()((input) =>
Effect.tapError((error) =>
Effect.gen(function* () {
const analytics = yield* Analytics;
const errorTag = error instanceof Error ? error.constructor.name : "UnknownError";
const errorTag =
Comment thread
aidenybai marked this conversation as resolved.
typeof error === "object" &&
error !== null &&
"_tag" in error &&
typeof error._tag === "string"
? error._tag
: // ignore for now
(error as any) instanceof Error
? (error as any).constructor.name
: "UnknownError";
Comment thread
NisargIO marked this conversation as resolved.
Comment thread
NisargIO marked this conversation as resolved.
yield* analytics.capture("run:failed", {
plan_id: "direct",
error_tag: errorTag,
Expand Down
Loading