Skip to content

fix(core): inherit nested target capabilities - #1478

Draft
aidenybai wants to merge 1 commit into
mainfrom
codex/internal-architecture-02-core-execution
Draft

fix(core): inherit nested target capabilities#1478
aidenybai wants to merge 1 commit into
mainfrom
codex/internal-architecture-02-core-execution

Conversation

@aidenybai

@aidenybai aidenybai commented Jul 29, 2026

Copy link
Copy Markdown
Member

What changed

When React Doctor is invoked from a nested directory without its own package manifest, capability detection now reads the nearest enclosing package.json and resolves Browserslist from that package root.

Why

The discovered project already inherited React/framework metadata from its enclosing package, but target-blank protection was computed against the nested directory. That could silently disable the rule for old browser and Electron targets.

Regression review

  • covers a nested Chrome 80 project requiring explicit noopener
  • covers a nested Electron 0.36 project requiring noreferrer
  • reuses the existing nearest-package helper; no new architecture or public API
  • full test suite, lint, typecheck, formatting, JSON-report smoke test all pass
  • React Doctor changed-scope scan: 100/100, no issues
  • patch changeset included

This PR is independent and targets main.

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1478
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1478
npm i https://pkg.pr.new/react-doctor@1478

commit: afd61af

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

React Doctor skipped this pull request — it changed no React files.

Reviewed by React Doctor for commit afd61af.

@aidenybai
aidenybai force-pushed the codex/internal-architecture-rewrite branch from 49cbd22 to 5b70e00 Compare July 30, 2026 03:03
@aidenybai
aidenybai force-pushed the codex/internal-architecture-02-core-execution branch from ce55017 to 9b6c1d1 Compare July 30, 2026 03:06
@aidenybai aidenybai changed the title [2/11] refactor(core): decompose scan execution pipeline fix(core): inherit nested target capabilities Jul 30, 2026
@aidenybai
aidenybai changed the base branch from codex/internal-architecture-rewrite to main July 30, 2026 03:06
@aidenybai
aidenybai force-pushed the codex/internal-architecture-02-core-execution branch from 9b6c1d1 to afd61af Compare July 30, 2026 03:16
@github-actions

Copy link
Copy Markdown
Contributor

Interactive terminal E2E

React Doctor interactive terminal recording

Recorded from the built CLI at afd61af in a real terminal. The fixture holds Git busy for three seconds, so Scanning... must appear immediately after project selection, then exercises the compact interactive report.

Download the GIF and MP4 artifact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant