[8/11] refactor(cli): migrate core imports to local facades

packages/react-doctor/src/cli/commands/rules.ts

@@ -1,6 +1,8 @@
 import * as path from "node:path";
-import { buildRuleDocsUrl, highlighter, validateConfigTypes } from "@react-doctor/core";
-import type { ReactDoctorConfig, RuleSeverityOverride } from "@react-doctor/core";
+import { validateConfigTypes } from "../../core/core-configuration.js";
+import type { ReactDoctorConfig, RuleSeverityOverride } from "../../core/core-configuration.js";
+import { highlighter } from "../../core/core-presentation.js";
+import { buildRuleDocsUrl } from "../../core/core-product.js";
 import { cliLogger as logger } from "../utils/cli-logger.js";
 import { METRIC } from "../utils/constants.js";
 import { recordCount } from "../utils/record-metric.js";

packages/react-doctor/src/cli/index.ts

@@ -1,5 +1,6 @@
 import { Command, Option } from "commander";
-import { CANONICAL_GITHUB_URL, CI_URL, highlighter } from "@react-doctor/core";
+import { highlighter } from "../core/core-presentation.js";
+import { CANONICAL_GITHUB_URL, CI_URL } from "../core/core-product.js";
 import { flushSentry, initializeSentry } from "../instrument.js";
 import { ciConfigAction, ciInstallAction, ciUpgradeAction } from "./commands/ci.js";
 import { designAction } from "./commands/design.js";

packages/react-doctor/src/cli/ink/components/diagnostic-detail.tsx

@@ -1,5 +1,5 @@
-import { getCategoryImpact } from "@react-doctor/core";
 import { Box, Text } from "ink";
+import { getCategoryImpact } from "../../../core/core-presentation.js";
 import { useMemo } from "react";
 import { buildCodeFrame } from "../../utils/build-code-frame.js";
 import { TUI_DETAIL_INDENT_COLUMNS } from "../../utils/constants.js";

packages/react-doctor/src/cli/ink/components/project-select.tsx

@@ -2,7 +2,7 @@ import path from "node:path";
 import figures from "figures";
 import { Box, Text, useInput } from "ink";
 import { useMemo, useState } from "react";
-import type { WorkspacePackage } from "@react-doctor/core";
+import type { WorkspacePackage } from "../../../core/core-types.js";
 import {
   TUI_PRINTABLE_ASCII_MIN_CODE_POINT,
   TUI_PROJECT_SELECT_CHROME_ROWS,

packages/react-doctor/src/cli/ink/components/report.tsx

@@ -1,6 +1,6 @@
 import { Box, Text, useInput } from "ink";
 import { useEffect, useMemo, useRef } from "react";
-import type { ScoreResult } from "@react-doctor/core";
+import type { ScoreResult } from "../../../core/core-types.js";
 import type { CliAgentId } from "../../utils/launch-agent.js";
 import {
   METRIC,

packages/react-doctor/src/cli/ink/components/scanning.tsx

@@ -1,6 +1,6 @@
 import { Box, Text } from "ink";
 import Spinner from "ink-spinner";
-import type { Diagnostic as LiveDiagnostic } from "@react-doctor/core/schemas";
+import type { LiveDiagnostic } from "../../../core/core-reporting.js";
 import { formatDiagnosticSite } from "../../utils/format-diagnostic-site.js";
 import { severityVariant } from "../lib/severity-variants.js";
 

packages/react-doctor/src/cli/ink/components/score-header.tsx

@@ -1,7 +1,8 @@
 import { Box, Text, useStdout } from "ink";
 import { useMemo } from "react";
-import { PERFECT_SCORE, SCORE_BAR_WIDTH_CHARS, TOP_ERRORS_DISPLAY_COUNT } from "@react-doctor/core";
-import type { ScoreResult } from "@react-doctor/core";
+import { SCORE_BAR_WIDTH_CHARS } from "../../../core/core-presentation.js";
+import { PERFECT_SCORE, TOP_ERRORS_DISPLAY_COUNT } from "../../../core/core-score.js";
+import type { ScoreResult } from "../../../core/core-types.js";
 import { doctorFace } from "../../utils/doctor-face.js";
 import {
   TUI_HORIZONTAL_PADDING_COLUMNS,

packages/react-doctor/src/cli/ink/lib/diagnostic-list-entries.ts

@@ -1,4 +1,4 @@
-import { DIAGNOSTIC_CATEGORY_BUCKETS } from "@react-doctor/core";
+import { DIAGNOSTIC_CATEGORY_BUCKETS } from "../../../core/core-diagnostic-semantics.js";
 import type { DiagnosticRow } from "./diagnostic-rows.js";
 
 export interface DiagnosticHeaderEntry {

packages/react-doctor/src/cli/ink/lib/diagnostic-rows.ts

@@ -1,4 +1,4 @@
-import type { Diagnostic, ScoreResult } from "@react-doctor/core";
+import type { Diagnostic, ScoreResult } from "../../../core/core-types.js";
 import {
   buildRulePriorityMap,
   buildSortedRuleGroups,

packages/react-doctor/src/cli/ink/lib/score-color.ts

@@ -1,4 +1,4 @@
-import { SCORE_GOOD_THRESHOLD, SCORE_OK_THRESHOLD } from "@react-doctor/core";
+import { SCORE_GOOD_THRESHOLD, SCORE_OK_THRESHOLD } from "../../../core/core-score.js";
 
 export const scoreColorName = (score: number): string => {
   if (score >= SCORE_GOOD_THRESHOLD) return "green";

packages/react-doctor/src/cli/ink/scan-bridge-layers.ts

@@ -1,7 +1,7 @@
 import * as Effect from "effect/Effect";
 import * as Layer from "effect/Layer";
-import { Progress, Reporter } from "@react-doctor/core";
-import type { ProgressHandle } from "@react-doctor/core";
+import { Progress, Reporter } from "../../core/core-runtime.js";
+import type { ProgressHandle } from "../../core/core-types.js";
 import type { ScanStore } from "./scan-store.js";
 
 export const reporterLayerForStore = (store: ScanStore): Layer.Layer<Reporter> =>

packages/react-doctor/src/cli/ink/scan-store.ts

@@ -1,8 +1,8 @@
-import type { Diagnostic, ScoreResult } from "@react-doctor/core";
+import type { Diagnostic, ScoreResult } from "../../core/core-types.js";
 // The live feed carries diagnostics exactly as `Reporter.emit` produces them
 // (the schema class), which differs from the index `Diagnostic` type only in
 // nested-array readonly-ness. The settled `report` keeps the index type.
-import type { Diagnostic as LiveDiagnostic } from "@react-doctor/core/schemas";
+import type { LiveDiagnostic } from "../../core/core-reporting.js";
 
 import { TUI_LIVE_FEED_MAX_ENTRIES } from "../utils/constants.js";
 import type { CliAgentId } from "../utils/launch-agent.js";

packages/react-doctor/src/cli/utils/apply-color-preference.ts

@@ -1,4 +1,4 @@
-import { setColorEnabled } from "@react-doctor/core";
+import { setColorEnabled } from "../../core/core-presentation.js";
 
 /**
  * Resolve an explicit color preference from `--color` / `--no-color` or the

packages/react-doctor/src/cli/utils/apply-observability.ts

@@ -1,7 +1,7 @@
 import * as Sentry from "@sentry/node";
 import * as Effect from "effect/Effect";
 import * as Tracer from "effect/Tracer";
-import { layerOtlp } from "@react-doctor/core";
+import { layerOtlp } from "../../core/core-runtime.js";
 import { TRACE_FLAG_SAMPLED } from "./constants.js";
 import { makeSentryTracer } from "./sentry-tracer.js";
 

packages/react-doctor/src/cli/utils/ask-add-to-github-actions.ts

@@ -1,4 +1,5 @@
-import { GITHUB_ACTIONS_SETUP_URL, highlighter } from "@react-doctor/core";
+import { highlighter } from "../../core/core-presentation.js";
+import { GITHUB_ACTIONS_SETUP_URL } from "../../core/core-product.js";
 import { cliLogger as logger } from "./cli-logger.js";
 import { CI_TRUST_COMPANIES } from "./constants.js";
 import { openUrl } from "./open-url.js";

packages/react-doctor/src/cli/utils/box-text.ts

@@ -1,4 +1,4 @@
-import { highlighter } from "@react-doctor/core";
+import { highlighter } from "../../core/core-presentation.js";
 
 // The ANSI escape introducer (built from its char code so the SGR patterns
 // below don't embed a control character in a regex literal).

packages/react-doctor/src/cli/utils/build-code-frame.ts

@@ -4,7 +4,7 @@ import {
   CODE_FRAME_LINES_ABOVE,
   CODE_FRAME_LINES_BELOW,
   CODE_FRAME_MAX_LINE_LENGTH_CHARS,
-} from "@react-doctor/core";
+} from "../../core/core-presentation.js";
 import { resolveAbsolutePath } from "./resolve-absolute-path.js";
 
 interface CodeFrameInput {

packages/react-doctor/src/cli/utils/build-diagnostic-issue-url.ts

@@ -1,5 +1,5 @@
-import { CANONICAL_GITHUB_URL } from "@react-doctor/core";
-import type { Diagnostic } from "@react-doctor/core";
+import { CANONICAL_GITHUB_URL } from "../../core/core-product.js";
+import type { Diagnostic } from "../../core/core-types.js";
 
 interface BuildDiagnosticIssueUrlInput {
   readonly diagnostic: Diagnostic;

packages/react-doctor/src/cli/utils/build-handoff-payload.ts

@@ -1,5 +1,5 @@
-import { TOP_ERRORS_DISPLAY_COUNT } from "@react-doctor/core";
-import type { Diagnostic } from "@react-doctor/core";
+import { TOP_ERRORS_DISPLAY_COUNT } from "../../core/core-score.js";
+import type { Diagnostic } from "../../core/core-types.js";
 import { HANDOFF_MAX_FILES_PER_RULE } from "./constants.js";
 import {
   buildSortedRuleGroups,

packages/react-doctor/src/cli/utils/build-no-score-message.ts

@@ -1,4 +1,4 @@
-import { ENTERPRISE_CONTACT_URL } from "@react-doctor/core";
+import { ENTERPRISE_CONTACT_URL } from "../../core/core-product.js";
 
 const ENTERPRISE_CONTACT_HINT = `Want something custom to your company? Contact us at ${ENTERPRISE_CONTACT_URL}.`;
 

packages/react-doctor/src/cli/utils/build-run-context.ts

@@ -1,4 +1,5 @@
-import { resolveLintBatchOrdering, scrubSensitivePaths } from "@react-doctor/core";
+import { scrubSensitivePaths } from "../../core/core-primitives.js";
+import { resolveLintBatchOrdering } from "../../core/core-scan-cache.js";
 import { detectTerminalKind } from "./detect-terminal-kind.js";
 import {
   detectCiEventName,

packages/react-doctor/src/cli/utils/build-section-divider.ts

@@ -1,4 +1,4 @@
-import { highlighter } from "@react-doctor/core";
+import { highlighter } from "../../core/core-presentation.js";
 import { resolveMeasureWidth } from "./resolve-measure-width.js";
 
 const DIVIDER_INDENT = "  ";

packages/react-doctor/src/cli/utils/build-sentry-project-context.ts

@@ -1,4 +1,4 @@
-import type { ProjectInfo } from "@react-doctor/core";
+import type { ProjectInfo } from "../../core/core-types.js";
 
 export interface SentryProjectContext {
   // Low-cardinality, searchable signals (framework, React major, capabilities)

packages/react-doctor/src/cli/utils/ci/ci-provider.ts

@@ -1,4 +1,4 @@
-import type { BlockingLevel, ScopeValue } from "@react-doctor/core";
+import type { BlockingLevel, ScopeValue } from "../../../core/core-types.js";
 
 // One CI backend React Doctor can scaffold and manage. GitHub Actions is the
 // fully supported provider; GitLab CI is a gate-only scaffold (no PR-opening,

packages/react-doctor/src/cli/utils/ci/manage-ci.ts

@@ -1,6 +1,7 @@
 import * as path from "node:path";
 import * as fs from "node:fs";
-import { CI_URL, GITHUB_ACTIONS_SETUP_URL, highlighter } from "@react-doctor/core";
+import { highlighter } from "../../../core/core-presentation.js";
+import { CI_URL, GITHUB_ACTIONS_SETUP_URL } from "../../../core/core-product.js";
 import { cliLogger as logger } from "../cli-logger.js";
 import { METRIC } from "../constants.js";
 import { detectDefaultBranch } from "../detect-default-branch.js";

packages/react-doctor/src/cli/utils/cli-logger.ts

@@ -1,6 +1,6 @@
 import * as Console from "effect/Console";
 import * as Effect from "effect/Effect";
-import { highlighter } from "@react-doctor/core";
+import { highlighter } from "../../core/core-presentation.js";
 
 /**
  * Thin synchronous façade over Effect's `Console` module. Used by

packages/react-doctor/src/cli/utils/cli-migrations.ts

@@ -1,4 +1,5 @@
-import { findLegacyConfig, toRelativePath } from "@react-doctor/core";
+import { findLegacyConfig } from "../../core/core-configuration.js";
+import { toRelativePath } from "../../core/core-primitives.js";
 import { cliLogger as logger } from "./cli-logger.js";
 import { type CliStateOptions } from "./cli-state-store.js";
 import { type Migration, type MigrationResult, runMigrations } from "./cli-lifecycle.js";

packages/react-doctor/src/cli/utils/colorize-by-score.ts

@@ -1,4 +1,5 @@
-import { highlighter, SCORE_GOOD_THRESHOLD, SCORE_OK_THRESHOLD } from "@react-doctor/core";
+import { highlighter } from "../../core/core-presentation.js";
+import { SCORE_GOOD_THRESHOLD, SCORE_OK_THRESHOLD } from "../../core/core-score.js";
 
 export const colorizeByScore = (text: string, score: number): string => {
   if (score >= SCORE_GOOD_THRESHOLD) return highlighter.success(text);

packages/react-doctor/src/cli/utils/compute-score-projection.ts

@@ -1,5 +1,5 @@
-import { calculateScore, TOP_ERRORS_DISPLAY_COUNT } from "@react-doctor/core";
-import type { Diagnostic, ScoreResult } from "@react-doctor/core";
+import { calculateScore, TOP_ERRORS_DISPLAY_COUNT } from "../../core/core-score.js";
+import type { Diagnostic, ScoreResult } from "../../core/core-types.js";
 import { buildRulePriorityMap } from "./diagnostic-grouping.js";
 import { getTopErrorRuleKeys } from "./render-diagnostics.js";
 

packages/react-doctor/src/cli/utils/count-unique-scanned-files.ts

@@ -1,4 +1,4 @@
-import type { InspectResult } from "@react-doctor/core";
+import type { InspectResult } from "../../core/core-types.js";
 
 export const countUniqueScannedFiles = (results: ReadonlyArray<InspectResult>): number => {
   const uniqueScannedFilePaths = new Set<string>();

packages/react-doctor/src/cli/utils/diagnostic-grouping.ts

@@ -1,11 +1,11 @@
 import {
-  buildRuleDocsUrl,
-  groupBy,
   hasPublishedFixRecipe,
   MIGRATION_SCALE_RULE_FILE_COUNT,
   MIN_SHARED_FIX_SITE_COUNT,
-} from "@react-doctor/core";
-import type { Diagnostic, ScoreResult } from "@react-doctor/core";
+} from "../../core/core-presentation.js";
+import { groupBy } from "../../core/core-diagnostic-semantics.js";
+import { buildRuleDocsUrl } from "../../core/core-product.js";
+import type { Diagnostic, ScoreResult } from "../../core/core-types.js";
 
 // Ordering / formatting helpers shared by the diagnostics renderer, the
 // agent-handoff payload builder, and the on-disk diagnostics writer — so

packages/react-doctor/src/cli/utils/diagnostic-intersects-line-ranges.ts

@@ -1,4 +1,4 @@
-import type { Diagnostic } from "@react-doctor/core";
+import type { Diagnostic } from "../../core/core-types.js";
 
 export const diagnosticIntersectsLineRanges = (
   diagnostic: Diagnostic,

packages/react-doctor/src/cli/utils/doctor-face.ts

@@ -1,4 +1,4 @@
-import { SCORE_GOOD_THRESHOLD, SCORE_OK_THRESHOLD } from "@react-doctor/core";
+import { SCORE_GOOD_THRESHOLD, SCORE_OK_THRESHOLD } from "../../core/core-score.js";
 
 export const doctorFace = (score: number): readonly [string, string] => {
   if (score >= SCORE_GOOD_THRESHOLD) return ["◠ ◠", " ▽ "];

packages/react-doctor/src/cli/utils/filter-diagnostics-by-categories.ts

@@ -1,4 +1,4 @@
-import type { Diagnostic } from "@react-doctor/core";
+import type { Diagnostic } from "../../core/core-types.js";
 
 export const filterDiagnosticsByCategories = (
   diagnostics: ReadonlyArray<Diagnostic>,

packages/react-doctor/src/cli/utils/get-staged-files.ts

@@ -1,6 +1,8 @@
 import * as Effect from "effect/Effect";
 import * as Layer from "effect/Layer";
-import { Git, StagedFiles, messageFromUnknown, type StagedSnapshot } from "@react-doctor/core";
+import { messageFromUnknown } from "../../core/core-errors.js";
+import { Git, StagedFiles } from "../../core/core-runtime.js";
+import type { StagedSnapshot } from "../../core/core-types.js";
 import { cliLogger } from "./cli-logger.js";
 
 const stagedFilesLayer = StagedFiles.layerNode.pipe(Layer.provide(Git.layerNode));

packages/react-doctor/src/cli/utils/handoff-to-agent.ts

@@ -1,7 +1,7 @@
 import * as fs from "node:fs";
 import { getSkillAgentConfig } from "agent-install";
-import type { Diagnostic } from "@react-doctor/core";
-import { highlighter } from "@react-doctor/core";
+import type { Diagnostic } from "../../core/core-types.js";
+import { highlighter } from "../../core/core-presentation.js";
 import { buildHandoffPayload } from "./build-handoff-payload.js";
 import { cliLogger as logger } from "./cli-logger.js";
 import { detectLaunchableAgents } from "./detect-launchable-agents.js";

packages/react-doctor/src/cli/utils/has-lint-hard-failure.ts

@@ -1,4 +1,4 @@
-import type { InspectResult } from "@react-doctor/core";
+import type { InspectResult } from "../../core/core-types.js";
 
 // `skippedChecks` carries "lint" only when the whole lint pass failed
 // (`didLintFail` in core's `build-skipped-checks`): an engine, plugin, or

packages/react-doctor/src/cli/utils/install-agent-hooks.ts

@@ -1,6 +1,6 @@
 import * as path from "node:path";
 import type { SkillAgentType } from "agent-install";
-import { isErrnoException } from "@react-doctor/core";
+import { isErrnoException } from "../../core/core-errors.js";
 import { AGENT_HOOK_TIMEOUT_SECONDS } from "./constants.js";
 import * as fs from "node:fs";
 import { CliInputError } from "./cli-input-error.js";

packages/react-doctor/src/cli/utils/install-git-hook-file.ts

@@ -4,7 +4,6 @@ import * as fs from "node:fs";
 import {
   ensureTrailingNewline,
   LEGACY_HOOK_RUNNER_RELATIVE_PATH,
-  NON_BLOCKING_REACT_DOCTOR_COMMAND,
   REACT_DOCTOR_COMMAND,
   runGit,
 } from "./git-hook-shared.js";
@@ -129,5 +128,3 @@ export const installDirectGitHook = (options: InstallGitHookOptions): InstallGit
     status: didHookExist ? "updated" : "created",
   };
 };
-
-export { NON_BLOCKING_REACT_DOCTOR_COMMAND, REACT_DOCTOR_COMMAND };

packages/react-doctor/src/cli/utils/install-react-doctor.ts

@@ -9,7 +9,8 @@ import {
   SKILL_MANIFEST_FILE,
   type SkillAgentType,
 } from "agent-install";
-import { highlighter, SKILL_NAME } from "@react-doctor/core";
+import { highlighter } from "../../core/core-presentation.js";
+import { SKILL_NAME } from "../../core/core-product.js";
 import { cliLogger as logger } from "./cli-logger.js";
 import { computeDefaultSelectedAgents, detectAvailableAgents } from "./detect-agents.js";
 import { readInstallAgents, rememberInstallAgents } from "./install-agents-preference.js";

packages/react-doctor/src/cli/utils/is-environment-error.ts

@@ -1,4 +1,4 @@
-import { isErrnoException, messageFromUnknown } from "@react-doctor/core";
+import { isErrnoException, messageFromUnknown } from "../../core/core-errors.js";
 
 // Filesystem conditions React Doctor cannot fix: a full or read-only disk, a
 // failing disk, denied permissions, or a path blocked by an existing file.

packages/react-doctor/src/cli/utils/is-expected-user-error.ts

@@ -1,4 +1,4 @@
-import { isProjectDiscoveryError, isReactDoctorError } from "@react-doctor/core";
+import { isProjectDiscoveryError, isReactDoctorError } from "../../core/core-errors.js";
 import { CliInputError } from "./cli-input-error.js";
 import { isEnvironmentError } from "./is-environment-error.js";
 

packages/react-doctor/src/cli/utils/is-inspect-result-complete.ts

@@ -1,5 +1,5 @@
-import { isScanComplete } from "@react-doctor/core";
-import type { InspectResult } from "@react-doctor/core";
+import { isScanComplete } from "../../core/core-reporting.js";
+import type { InspectResult } from "../../core/core-types.js";
 
 export const isInspectResultComplete = (result: InspectResult): boolean =>
   isScanComplete({

packages/react-doctor/src/cli/utils/is-share-opted-out.ts

@@ -1,4 +1,4 @@
-import type { ReactDoctorConfig } from "@react-doctor/core";
+import type { ReactDoctorConfig } from "../../core/core-configuration.js";
 
 // A scanned project as the aggregate share gate sees it: only its merged
 // (root + module) config matters.

packages/react-doctor/src/cli/utils/json-mode.ts

@@ -1,8 +1,8 @@
 import { performance } from "node:perf_hooks";
 import * as fs from "node:fs";
 import * as path from "node:path";
-import { buildJsonReportError } from "@react-doctor/core";
-import type { JsonReport, JsonReportMode } from "@react-doctor/core";
+import { buildJsonReportError } from "../../core/core-reporting.js";
+import type { JsonReport, JsonReportMode } from "../../core/core-reporting.js";
 import { INTERNAL_ERROR_JSON_FALLBACK } from "./constants.js";
 import { makeNoopConsole } from "./noop-console.js";
 import { VERSION } from "./version.js";

packages/react-doctor/src/cli/utils/materialize-baseline-files.ts

@@ -1,10 +1,10 @@
 import * as Effect from "effect/Effect";
+import { Git } from "../../core/core-runtime.js";
+import type { MaterializedTree } from "../../core/core-types.js";
 import {
   GIT_SHOW_MAX_BUFFER_BYTES,
-  Git,
-  type MaterializedTree,
   materializeSourceTree,
-} from "@react-doctor/core";
+} from "../../core/core-version-control.js";
 import { isMaterializableGitSource } from "./is-materializable-git-source.js";
 
 export interface BaselineMaterializedTree extends MaterializedTree {

packages/react-doctor/src/cli/utils/migrate-legacy-config.ts

@@ -1,5 +1,5 @@
 import * as path from "node:path";
-import type { LegacyConfigLocation } from "@react-doctor/core";
+import type { LegacyConfigLocation } from "../../core/core-types.js";
 import { readObjectFile } from "./read-object-file.js";
 import { serializeTsObjectLiteral } from "./serialize-ts-object-literal.js";
 import * as fs from "node:fs";

packages/react-doctor/src/cli/utils/onboarding-state.ts

@@ -1,4 +1,4 @@
-import { type CliStateOptions, ONBOARDING_EVENT, getCliStatePath } from "./cli-state-store.js";
+import { type CliStateOptions, ONBOARDING_EVENT } from "./cli-state-store.js";
 import { type Gate, isGatePending, recordGate } from "./cli-lifecycle.js";
 
 // The first-run onboarding reveal, expressed as a global gate: it fires once
@@ -7,8 +7,6 @@ import { type Gate, isGatePending, recordGate } from "./cli-lifecycle.js";
 // machinery supports both with no other change.
 export const ONBOARDING_GATE: Gate = { id: ONBOARDING_EVENT, scope: "global" };
 
-export const getOnboardingConfigPath = getCliStatePath;
-
 // `isGatePending` defaults to "not pending" on an unreadable store, so this
 // fails safe to "already onboarded" — a broken config dir never replays the
 // reveal.