fix: clear GIT_DIR for nested git commands in scoped scans

[skoshx]

Problem

Git hooks export GIT_DIR, which causes nested git commands to ignore the scoped cwd and return repository-root paths instead. This results in ENOENT errors when scanning subdirectories from within git hooks.

Root Cause

When React Doctor is invoked from a Git hook (e.g., pre-commit, pre-push), the GIT_DIR environment variable is set. This variable is inherited by nested git commands spawned by React Doctor. When these nested commands run with a scoped cwd (e.g., webapp/), git ignores the cwd and resolves paths relative to GIT_DIR instead, returning repository-root paths that don't exist relative to the scan directory.

Fix

Explicitly clear GIT_DIR in the environment when spawning git commands, while preserving other git-related environment variables like GIT_INDEX_FILE. This ensures that nested git commands respect the provided cwd parameter.

Scope

The fix is minimal and surgical:

• Clears only GIT_DIR when spawning git commands (not other commands)
• Preserves all other environment variables including GIT_INDEX_FILE
• No behavior change for scans outside of git hooks

Testing

Added regression test in issue-1501-git-dir-scoped-scan.test.ts covering:

• Scoped scans returning relative paths when GIT_DIR is set
• Preventing repository-root paths in subdirectory scans
• Preserving GIT_INDEX_FILE when clearing GIT_DIR

Closes #1501

  

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1502

npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1502

npm i https://pkg.pr.new/react-doctor@1502

commit: 2a14939

[github-actions]

Interactive terminal E2E

Recorded from the built CLI at 2a14939 in a real terminal. The fixture holds Git busy for three seconds, so Scanning... must appear immediately after project selection, then exercises the compact interactive report.

Download the GIF and MP4 artifact