[ARCHIVE] Typed-expression AST infrastructure (saved for future revival) - #4
Open
milyin wants to merge 1 commit into
Open
[ARCHIVE] Typed-expression AST infrastructure (saved for future revival)#4milyin wants to merge 1 commit into
milyin wants to merge 1 commit into
Conversation
Snapshot of the typed-expression AST/expr infrastructure that was removed from main in PR #2 (commit 1f2c224). Restored on top of current main so the diff shows the full infrastructure as an additive change for future revival. This branch is an archive only and is NOT intended to be merged: it does not reconcile with the Kt-prefix renames or the overload-validation change that now live on main. To revive this work, cherry-pick or re-integrate the expr module and its bindings on top of the current model. Raw pre-cleanup source is also preserved on branch backup/before-cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ARCHIVE] Typed-expression AST infrastructure — saved for future revival
This PR is not intended to be merged. It preserves the typed-expression
AST /
exprmodule that was removed frommainin #2, so the work is easy tofind, review, and revive later.
Why a separate archive PR
The AST was part of the codebase since the initial import, so a PR from the
original pre-cleanup branch (
backup/before-cleanup) shows an almost-emptydiff — GitHub diffs against the merge-base, which already contained the AST.
To make the infrastructure actually visible as a diff, this branch restores
those files on top of the current (AST-free)
main, yielding a clean additivediff of ~3.6k lines.
What's here
Restores the full typed-expression layer:
src/expr.rs,src/expr/render.rs,src/expr/tests.rs— the AST model,renderer, and its test suite
model.rs,slot.rs,render.rs,lib.rs,file.rs,code.rs, and tests that integrated the ASTKey types being preserved:
ExprArena,KtExpr,KtStmt,KtLambda,KtLiteral,KtPattern,KtName,BindingId/ArenaId,Binder,ExprSlot<T>,Ast<T>,AnnotationSlot/KtAnnotation,KtAccessor, andKtFun::typed_body.Caveats (archive, not mergeable)
Kt-prefix renames and the overload-validation change thatnow live on
mainfor the affected files. Reviving this work meansre-integrating the
exprmodule on top of currentmain, not merging as-is.Raw pre-cleanup source is also preserved on branch
backup/before-cleanup.Companion to #2 (the cleanup that removed this infrastructure).