Closed
Conversation
lgalende
reviewed
Jan 5, 2026
Member
lgalende
left a comment
There was a problem hiding this comment.
In general, we do:
if (...) something()
// or
if (...) {
somethingTooLongThatDoesNotFitOneLine()
}but not:
if (...)
somethingTooLongThatDoesNotFitOneLine()
lgalende
reviewed
Jan 7, 2026
Member
lgalende
left a comment
There was a problem hiding this comment.
WDYT about adding the following cases to the commands tests?
- when the mimic config exists
- when the mimic config does not exist
Member
|
I know I requested it, but I've rolled back the constants to keep this PR clean. We can do it in a separate issue. |
lgalende
reviewed
Jan 9, 2026
Member
lgalende
left a comment
There was a problem hiding this comment.
If the command fails for one of the tasks, then the rest of the task aren't executed.
For example, if I want to deploy 10 tasks, and task-4 fails, then tasks 5 to 10 deployments don't run. Should they run anyway?
alavarello
reviewed
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed:
mimic.yamlconfiguration file support for multi-taskMimicConfigHandlerto load and validatemimic.yamlconfigurations--includeand--excludeflags to all CLI commands for task filteringmimic.yamldoesn't exist