Add loggable property#719
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for dynamically enabling Mindbox SDK logging via Android’s per-tag log system property (log.tag.Mindbox), allowing log verbosity to be influenced at runtime (e.g., via adb shell setprop ...).
Changes:
- Added a
setPropLevel()check usingLog.isLoggable(TAG, Log.DEBUG)to allow a setprop override. - Updated logger methods (
i/d/w/e) to log when either the configured SDKlevelor the setprop-derived level allows it. - Made
Level.valueimmutable (var→val).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/src/main/java/cloud/mindbox/mobile_sdk/logger/MindboxLoggerImpl.kt | Adds setprop-based log enabling and integrates it into log level checks. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/logger/Level.kt | Makes Level.value immutable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sergeysozinov
approved these changes
May 26, 2026
enotniy
force-pushed
the
feature/add_log_property
branch
from
77aeece to
93ff6f9
Compare
enotniy
force-pushed
the
feature/add_log_property
branch
from
93ff6f9 to
6b5c6bc
Compare
enotniy
force-pushed
the
feature/add_log_property
branch
from
13d98b3 to
5f06f83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support command
adb shell setprop "log.tag.Mindbox" "${LEVEL}"