feat: map anton's new StreamReasoningDelta to thought.progress subtype:reasoning (ENG-1109) - #241
Open
torrmal wants to merge 1 commit into
Open
feat: map anton's new StreamReasoningDelta to thought.progress subtype:reasoning (ENG-1109)#241torrmal wants to merge 1 commit into
torrmal wants to merge 1 commit into
Conversation
…e:reasoning (ENG-1109) Matches hermes_harness's existing thought.progress + subtype shape exactly, so the frontend's ephemeral "current thought" handling (built for ENG-1108) picks this up identically with no client-side change. Companion to mindsdb/anton#280, which adds the StreamReasoningDelta event and starts emitting it for both Claude (extended thinking) and OpenAI (reasoning summary / reasoning_content). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
No PR environment for this pull requestAdd the Updated on every push to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to mindsdb/anton#280, which adds a new
StreamReasoningDeltaevent to Anton's provider layer and starts emitting it — for Claude's extended-thinking content blocks and OpenAI's reasoning-summary/reasoning_content— instead of either silently dropping it or letting narration text leak into the final answer.This PR is the small piece that lets it actually reach the client: maps
StreamReasoningDelta→response.in_progresswiththought_role: thought.progress,content,subtype: reasoninginanton_harness/stream_formatter.py. That's the exact shapehermes_harness/stream_formatter.pyalready emits, and the exact shape the frontend'sresponseStreamAdapter.jsalready reads (built for cowork's ENG-1108, the ephemeral "current thought" UI) — so no frontend change is needed at all.Linear: https://linear.app/mindsdb/issue/ENG-1109/anton-capture-claudeopenai-reasoning-as-a-real-subtypereasoning
Test plan
tests/test_anton_stream_formatter.py— asserts aStreamReasoningDeltamaps to the correctthought_role/subtype/contentshape, and (critically) never leaks intoresponse.output_text.deltaalongside real answer textfeat/eng-1109-reasoning-subtype-channel, i.e. anton#280) viaPYTHONPATHoverride to exercise the realStreamReasoningDeltatype end-to-end — passes🤖 Generated with Claude Code