Skip to content

Downloads shelf - #484

Open
ianu82 wants to merge 3 commits into
pr/tab-shortcutsfrom
pr/downloads-shelf
Open

Downloads shelf#484
ianu82 wants to merge 3 commits into
pr/tab-shortcutsfrom
pr/downloads-shelf

Conversation

@ianu82

@ianu82 ianu82 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What

Downloads stop disappearing into the void. The browser toolbar gains a downloads button that shows live progress while anything is downloading, and opens a shelf listing this session's downloads: filename, progress percent while running, then final size, Cancelled, or Failed.

  • Clicking a finished row reveals the file in Finder.
  • The main process tracks the session partition's will-download events and folds them into the shared state push — the shelf itself is presentation only.
  • Like the omnibox dropdown, the shelf hides the native WebContentsView while open so it never renders behind the page.

Two small follow-up commits type the download listeners in the browser-manager tests and harden the fixture's download handler. Stacked on pr/tab-shortcuts.

For QA

  1. Download any file: the toolbar button animates with progress and the shelf lists the item with a live percentage.
  2. When it finishes, the row shows the final size; clicking it reveals the file in Finder.
  3. Cancel a download mid-flight (or pull the network): the row flips to Cancelled / Failed and the button stops spinning.
  4. The shelf renders over the page; clicking outside closes it and the page returns.
  5. Download several files: all appear, newest state wins, no duplicates.

ianu82 added 3 commits July 23, 2026 10:32
Main now tracks every will-download item into the state push (last 10,
newest first, session-only): deduped filename, received/total bytes,
progressing → completed/cancelled/interrupted. The nav row gains a
downloads button (accent dot while something is in flight) whose shelf
lists each file with a progress bar or status; a row click reveals it
in Finder/Explorer via the existing showItemInFolder. The shelf hides
the native view while open, same rule as the omnibox dropdown.
@ianu82
ianu82 force-pushed the pr/tab-shortcuts branch from 1ef4c7d to bb62636 Compare July 23, 2026 17:44
@ianu82
ianu82 force-pushed the pr/downloads-shelf branch from bda3509 to ec16bd7 Compare July 23, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant